Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions deploy/.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ WEB_PORT=8080
# In Docker, this should use the service name 'server'
API_URL=http://server:8000

# =============================================================================
# Authentication Configuration
# =============================================================================
# ORCiD OAuth credentials (required for login)
# Register at https://orcid.org/developer-tools
ORCID_CLIENT_ID=
ORCID_CLIENT_SECRET=
Comment on lines +43 to +44

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ORCiD env vars are defined but never wired

ORCID_CLIENT_ID and ORCID_CLIENT_SECRET are defined here but deploy/docker-compose.yml does not map them to the OSA_AUTH__PROVIDERS__ORCID__CLIENT_ID / OSA_AUTH__PROVIDERS__ORCID__CLIENT_SECRET env vars the server expects. The JWT value is correctly mapped in docker-compose.yml, but the ORCiD credentials are missing. Without that mapping, deployers who fill in these values will find that ORCiD login is never enabled.

The server service's environment: section in docker-compose.yml needs corresponding entries to forward these values.


# JWT secret for signing access tokens (min 32 characters)
# Generate with: openssl rand -hex 32
JWT_SECRET=change-me-in-production-must-be-32-chars-long

# =============================================================================
# Development Settings (optional)
# =============================================================================
Expand Down
1 change: 0 additions & 1 deletion sdk/py/README.md

This file was deleted.

29 changes: 0 additions & 29 deletions sdk/py/osa/__init__.py

This file was deleted.

128 changes: 0 additions & 128 deletions sdk/py/osa/_registry.py

This file was deleted.

13 changes: 0 additions & 13 deletions sdk/py/osa/authoring/__init__.py

This file was deleted.

36 changes: 0 additions & 36 deletions sdk/py/osa/authoring/convention.py

This file was deleted.

18 changes: 0 additions & 18 deletions sdk/py/osa/authoring/hook.py

This file was deleted.

36 changes: 0 additions & 36 deletions sdk/py/osa/authoring/source.py

This file was deleted.

5 changes: 0 additions & 5 deletions sdk/py/osa/authoring/validator.py

This file was deleted.

Loading
Loading