Fix for possible crashing on start#40
Merged
Merged
Conversation
- C string functions work with byte arrays and are perfectly happy with UTF-8, which is backward-compatible with ASCII. - iOS file paths support full Unicode. This way we handle the nil properly and also use modern utf8
ebariaux
requested changes
Mar 4, 2026
Contributor
ebariaux
left a comment
ebariaux
left a comment
There was a problem hiding this comment.
Just added a comment because I wasn't sure at first what this reopen was doing
Co-authored-by: Eric Bariaux <375613+ebariaux@users.noreply.github.com>
NSSearchPathForDirectoriesInDomains is no longer available in Swift with the iOS 18.5 SDK (Xcode 16.4), which macos-latest now uses.
ebariaux
approved these changes
Mar 5, 2026
Contributor
ebariaux
left a comment
ebariaux
left a comment
There was a problem hiding this comment.
Apologies, it's the suggestion that I made that deleted the line initiliazing paths variable.
But anyway it's better to use the FileManager API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we handle the nil properly and also use modern utf8
fix #39