Fix Windows install: route Git Bash to PS1, pin tar to bsdtar#4
Open
yyy900 wants to merge 1 commit into
Open
Conversation
install.sh treated Git Bash as an unsupported platform: `uname -s` returns MINGW64_NT-... which fell through to the error branch. Add a MINGW*/MSYS*/CYGWIN* case that points Windows users at the PowerShell installer instead. install.ps1 ran `tar -xzf` against paths like C:\Users\...; a GNU tar from Git Bash on PATH parses the "C:" as a remote host (tar: Cannot connect to C: resolve failed). Pin extraction to Windows' bundled bsdtar at System32\tar.exe, which handles drive letters. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
My new jio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Windows install failures, both in the bootstrap scripts:
install.shreportedunsupported platform: MINGW64_NT-...— Git Bash'suname -sreturnsMINGW64_NT-..., which fell through theDarwin/Linuxcase to the error branch. Windows is supported (via the PowerShell installer), so the message was misleading. Added aMINGW*|MSYS*|CYGWIN*case that points the user at the PowerShell one-liner.install.ps1died withtar: Cannot connect to C: resolve failed—tar -xzfran against paths likeC:\Users\.... When a GNU tar from Git Bash is first onPATH, it parses theC:as ahost:pathremote and tries to connect to hostC. Pinned extraction to Windows' bundled bsdtar at%SystemRoot%\System32\tar.exe, which handles drive letters.Still open (not in this PR — hosting config)
agent.openonion.ai/install.ps1currently 404s and/installonly 307-redirects toinstall.sh. The PowerShell short URL needs a Vercel route (serve the.ps1directly, 200, no redirect) beforeirm agent.openonion.ai/install.ps1 | iexworks. This PR'sinstall.shmessage points at the raw GitHub URL to avoid that dependency.Test plan
sh -n install.shpassescurl -fsSL agent.openonion.ai/install | shprints the PowerShell redirect instead of "unsupported platform"irm https://raw.githubusercontent.com/openonion/oo/main/install.ps1 | iexextracts CPython without thetar: Cannot connect to C:error🤖 Generated with Claude Code