reproduction: middleware rewrite breaks client-side navigation on SSG target (#1170)#1171
Merged
sommeeeer merged 6 commits intoMay 21, 2026
Conversation
🦋 Changeset detectedLatest commit: 943d8c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…es work on client-side navigation (opennextjs#1170)
Collaborator
|
Great work on this one @troendheim ! Would you mind adding a changeset? |
sommeeeer
reviewed
May 20, 2026
commit: |
Contributor
Author
|
@sommeeeer haven't used changesets before so I'm unsure if it's up to par. If not, please let me know 😄 |
conico974
approved these changes
May 20, 2026
conico974
left a comment
conico974
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for this @troendheim
Contributor
Author
|
@conico974 No problem. Btw I wasn't aware that I broke the unit tests. I'll push a change :-) |
sommeeeer
approved these changes
May 21, 2026
Collaborator
There was a problem hiding this comment.
LGTM, great work on this one @troendheim!
I'll merge when CI is done and green
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends e2e tests and page router example with a currently broken handling of rewrites as per issue #1170