Skip to content

fix(build): add empty loader for .node files in esbuild #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clichedmoog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(build): add empty loader for .node files in esbuild #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/esbuild-node-loader.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

fix(build): add empty loader for .node files in esbuild to prevent build crashes
2 changes: 2 additions & 0 deletions packages/open-next/src/build/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export function esbuildSync(
sourcemap: debug ? "inline" : false,
sourcesContent: false,
...esbuildOptions,
loader: { ".node": "empty", ...esbuildOptions.loader },
external: ["./open-next.config.mjs", ...(esbuildOptions.external ?? [])],
banner: {
...esbuildOptions.banner,
Expand Down Expand Up @@ -163,6 +164,7 @@ export async function esbuildAsync(
sourcemap: debug ? "inline" : false,
sourcesContent: false,
...esbuildOptions,
loader: { ".node": "empty", ...esbuildOptions.loader },
external: [
...(esbuildOptions.external ?? []),
"next",
Expand Down
Loading