Skip to content

address lint errors for usage of any#19

Merged
james-elicx merged 4 commits into
mainfrom
j-branch-6
Feb 3, 2026
Merged

address lint errors for usage of any#19
james-elicx merged 4 commits into
mainfrom
j-branch-6

Conversation

@james-elicx

@james-elicx james-elicx commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

This PR enforces the no-explicit-any lint rule in aws.

As a result, I've done the following;

  • Added ts:check script in aws so it runs as part of the ts:check job in CI.
  • Replaced usage with unknown.
  • Defined concrete types in places where they're known or summised.
  • Used more relevant type assertions in certain areas.
  • In a few cases, the rule is ignored when we don't have a better alternative.
  • Some of the generic function signatures and how they are used were altered to better reflect unknown types.

There should be no change to the actual behaviour of the adapter in this PR.

@pkg-pr-new

pkg-pr-new Bot commented Feb 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@19
npm i https://pkg.pr.new/@opennextjs/aws@19

commit: 8f0a3e6

@james-elicx james-elicx marked this pull request as ready for review February 3, 2026 08:17
@james-elicx james-elicx requested review from sommeeeer and vicb February 3, 2026 08:17

@vicb vicb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I still found some comments to add ;)
Some of the commented code has repeated occurences, I commented only once.

Comment thread packages/open-next/src/adapters/image-optimization-adapter.ts Outdated
Comment thread packages/open-next/src/core/requestHandler.ts
Comment thread packages/open-next/src/overrides/wrappers/aws-lambda-compressed.ts Outdated
Comment thread packages/open-next/src/overrides/wrappers/aws-lambda-compressed.ts Outdated
@james-elicx james-elicx linked an issue Feb 3, 2026 that may be closed by this pull request
@james-elicx james-elicx merged commit ceebcd7 into main Feb 3, 2026
6 checks passed
@james-elicx james-elicx deleted the j-branch-6 branch February 3, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enforce no-explicit-any in core

2 participants