SDK-less implementation of Dropbox, Microsoft and box.com providers#113
Open
TranceLove wants to merge 8 commits into
Open
SDK-less implementation of Dropbox, Microsoft and box.com providers#113TranceLove wants to merge 8 commits into
TranceLove wants to merge 8 commits into
Conversation
TranceLove
changed the title
TranceLove
force-pushed
the
feature/sdkless-dropbox-microsoft
branch
from
56ad0dc to
c33d888
Compare
TranceLove
force-pushed
the
feature/sdkless-dropbox-microsoft
branch
2 times, most recently
from
7cfec86 to
70315a2
Compare
TranceLove
changed the title
TranceLove
force-pushed
the
feature/sdkless-dropbox-microsoft
branch
from
9f7049a to
ec4b1bc
Compare
TranceLove
force-pushed
the
feature/sdkless-dropbox-microsoft
branch
from
35ed953 to
84d0be2
Compare
4 tasks
Signed-off-by: Raymond Lai <airwave209gt@gmail.com>
For better compatibility with legacy apps that cannot migrate to Google's Material Design Library with Material 3 designs yet. Signed-off-by: Raymond Lai <airwave209gt@gmail.com>
Also added adaptation to try match host's day/night theme Signed-off-by: Raymond Lai <airwave209gt@gmail.com>
Signed-off-by: Raymond Lai <airwave209gt@gmail.com>
- Add Github Actions files for new plugins - Updated dependencies in build.gradle Signed-off-by: Raymond Lai <airwave209gt@gmail.com>
Signed-off-by: Raymond Lai <airwave209gt@gmail.com>
So developers can just use plugin-google-nongms alone, without being tied to Google's closed source libraries Signed-off-by: Raymond Lai <airwave209gt@gmail.com>
Chrome Webview -> AndroidX Browser CustomTab Signed-off-by: Raymond Lai <airwave209gt@gmail.com>
TranceLove
force-pushed
the
feature/sdkless-dropbox-microsoft
branch
from
47582d5 to
55155cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of OMH Auth API for Dropbox, Microsoft and box.com OAuth providers using Webview, instead of SDK provided by vendor.
This greatly reduces the overhead brought by including vendors' SDK, as well as enable usage scenarios where API credentials cannot be embedded into the source tree directly.
Will involve URI redirect for webviews though, in order to allow app to take control when the OAuth2 callback is triggered. Documentation had been updated to provide information regarding this.
The ID tokens included in the PR are for testing. They had been expired for long, and they should pose no security risks.
Tweaks
Since the three implementations also uses webview, which is similar to google-nongms plugin in many ways, their common code and routines had been extracted to a new module plugin-common-mobileweb, where implementations (including google-nongms) depends on.
Because of this change, Github workflow part will also need changes for publishing the new modules. However they should be handled in another PR.
Additionally, the compilation options are also updated to use updated Gradle plugin, use JDK 17 and SDK 35 to compile.
Demo
Login flow of Dropbox, Microsoft and box.com via Mobile Web had been added to the sample app.
Screen_recording_20250607_230635.mp4
Checklist: