feat: enable debugging for service providers with workload cluster#35
Merged
Conversation
AndresNico
changed the title
christophrj
requested changes
Jul 14, 2026
christophrj
left a comment
christophrj
left a comment
Member
There was a problem hiding this comment.
Thanks @AndresNico generally lgtm 👍 please have a look at a couple of minor change requests regarding naming and realizing the feature without a breaking change.
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres <nico.andres@sap.com>
christophrj
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-behalf-of: @SAP nico.andres@sap.com
What this PR does / why we need it:
Currently locally running a service provider which uses a workload cluster with
DEV_DEBUG=truedoes not work. The localAccessReconciler patches the restConfig and client of both clusters to use localhost instead of the IP on the docker network. This is fine for the sp but not for the deployed workload which needs to access the target cluster with the IP and port on the docker network.This PR adds a
withWorkloadparam option to thelocalAdvancedClusterAccessReconcilerwhich results in patching the cluster client to use localhost and the restConfig to use the host on the docker network.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: