Sync cmk#285
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Doanh Luong <doanh.luong@sap.com>
jmpTeixeira02
force-pushed
the
sync-cmk
branch
2 times, most recently
from
0f1c9a1 to
a8b0f20
Compare
jmpTeixeira02
force-pushed
the
sync-cmk
branch
3 times, most recently
from
b69a1b6 to
b4df104
Compare
* feat: system filter options * feat: allow filtering of items for get filters * chore: more tests for get filter options Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
* refactor: remove detailedworkflow and added workflow opt WithDetails * feat: put system state as under workflow on workflow creation * Merge branch 'main' into task/system-under-workflow-data Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Niaz Khan <niazkhansap@gmail.com>
* feat: update OpenAPI spec for get workflow * feat: add check for eligible approvers, initiator * fix: address comments Signed-off-by: Doanh Luong <doanh.luong@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
…lient data headers * : migrate controller tests to ClientDataMiddleware. Align testutils and controller test suites with signed client data headers so migrated tests run against the new middleware behavior. Co-authored-by: Cursor <cursoragent@cursor.com> * Linter errors * addressed comments * addressed comments 2 * linter error -------- Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: David Bolet <davidbolet@gmail.com> Signed-off-by: David <davidbolet@gmail.com>
Remove the appVersion fallback in the image helper — if neither tag nor digest is set, helm now fails with a clear error. If both are set, digest takes precedence. Bump chart version 0.1.69 -> 0.1.70. Signed-off-by: Johannes Pusch <johannes.pusch@sap.com>
Bump cmk chart version Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
* feat: create workflow_approver_groups table * feat: use workflow_approver_groups table instead of jsonb * chore: add fallback while data migration is not finished * chore: merge main Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Peter Bingham <p.bingham@sap.com>
Signed-off-by: Niaz Khan <niazkhansap@gmail.com>
* feat: create docker containers for cmk services * fix: buildkit with testcontainer in time image build * refactor: shared implementation of start status server * feat: add status server to cli * feat: test enqued task finishes * feat: async integration tests * chore: linter * feat: parallelism on integration container setup * fix: move from openkcm * chore: split args in cmd Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: bkieling <8618270+bkieling@users.noreply.github.com>
Signed-off-by: Niaz Khan <niazkhansap@gmail.com>
* fix(deps): update all dependencies * update business_user_data_test.go to use common-sdk format -------- Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
* chore: change clientData helper to accept certificate as input * chore: clean up local env and unnecessary make targets * fix: make create tenant also create default groups * chore: update readme * chore: move charts to charts/cmk * fix: missing plugins for tenant-manager * fix: error not printing on cli * chore: coverage for client headers Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
Signed-off-by: Joao Teixeira <joao.teixeira01@sap.com>
jmpTeixeira02
requested review from
MarkMcAleese,
anettlippert,
bkieling,
doanhluongsap and
minh-nghia
bkieling
approved these changes
Jun 1, 2026
doanhluongsap
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test