Add internal user authz#224
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis pull request introduces a comprehensive refactoring of the authorization system to distinguish between business users and internal system roles. Key changes include: splitting the single Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c3180e4 to
8d31f20
Compare
minh-nghia
left a comment
There was a problem hiding this comment.
Will also need to cover event reconciler, mainly these functions:
resolveTasks, confirmJob, jobDoneFunc, jobFailedFunc, jobCanceledFunc
|
@coderabbitai /summarize |
|
✅ Actions performedSummary regeneration triggered. |
| r := sql.NewRepository(dbCon) | ||
|
|
||
| sis, err := manager.NewSystemInformationManager(r, svcRegistry, &cfg.ContextModels.System) | ||
| sis, err := manager.NewSystemInformationManager(r, nil, svcRegistry, &cfg.ContextModels.System) |
There was a problem hiding this comment.
same here, maybe we can have two functions: NewSystemInformationManager NewSystemInformationManagerWithoutAuthz so it is more clear
There was a problem hiding this comment.
This also applies to the NewSystemManager. I think the problem is more that this really should have the loader and not nil, so there is basically missing authz here, which I've fixed. Thanks for pointing this out.
There are still instances in the test code where this is nil. Based on previous comment by @jmpTeixeira02 the preference is to avoid lists of specifically named functions (although I'll leave Joao to comment if the context is different here) and also 1) now that this only affects test code I don't think worth introducing another function for this; 2) other parameters are set to nil in the test code (eg eventsFactory for newSystemManager).
8d31f20 to
e0b45c8
Compare
e0b45c8 to
611cf38
Compare
What this PR does / why we need it:
Special notes for your reviewer:
Release note:
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores