Check author when showing scope notes and votes#1551
Merged
Conversation
sneakers-the-rat
approved these changes
Jun 12, 2026
sneakers-the-rat
left a comment
Contributor
There was a problem hiding this comment.
Yep this hides the panels on the deployed preview!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new method to the
Papermodel to check if a given user is the submitting author and updates the UI to restrict editors from seeing certain sections for their own submissions. It also adds tests to ensure the new method works as expected.Model changes:
submitted_by?(user)method to thePapermodel to determine if a given user is the submitting author.UI changes:
_show_unpublished.html.erb) so that editors do not see the "vote summary" and "notes" sections for papers they themselves submitted.Testing:
submitted_by?method inpaper_spec.rbto verify correct behavior for the submitting author, other users, and nil cases.Fixes #1550