Clarify an empty object in a VP Token cannot be used to signify an error response#745
Draft
awoie wants to merge 1 commit into
Draft
Clarify an empty object in a VP Token cannot be used to signify an error response#745awoie wants to merge 1 commit into
awoie wants to merge 1 commit into
Conversation
Contributor
Author
|
We probably will need to apply this logic to DC API as well. I will need to double check if this is included with the current proposed text. |
fkj
approved these changes
Jun 19, 2026
fkj
left a comment
fkj
left a comment
Member
There was a problem hiding this comment.
If people don't object to the rewriting of the definition, I agree that this makes it easier to understand what we actually mean.
c2bo
reviewed
Jun 22, 2026
| * Each Presentation MUST be encoded as a string or object according to | ||
| (#format_specific_parameters). | ||
|
|
||
| * The object MAY be empty only if the DCQL query can be satisfied without |
Member
There was a problem hiding this comment.
Something like this might make it more clear imho?
Suggested change
| * The object MAY be empty only if the DCQL query can be satisfied without | |
| * The object MUST NOT be empty unless the DCQL query can be satisfied without |
paulbastian
reviewed
Jun 22, 2026
Comment on lines
+1179
to
+1180
| * The object MUST NOT contain an entry for an optional Credential Query when | ||
| there are no matching Credentials for that Credential Query. |
Contributor
There was a problem hiding this comment.
This is hard to understand for me, is this repeating things from DCQL rules? Why "optional"?
Contributor
There was a problem hiding this comment.
I think this line is rather confusing and repeating DCQL rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743
I also improved the vp_token definition because it is a quite important part of the spec and the readability was not great.
I removed this editorially because I don't think it had any meaning anymore: