Add missing CV-X-IF register interface signals#326
Conversation
|
Hi @LuisDonatien, thanks for this PR. Do you have any VIP related to this update you could share? This changes adds considerable complexity and our testbench currently lacks any means to test it. |
|
Hello @MikeOpenHWGroup, I used an IP derived from the CVA6 |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks @LuisDonatien. It LTGM. I've assigned this review to @davideschiavone (the Committer who originally added the X-IF to this core), and also to CoPilot - just to see what it says. |
Add missing register ACK signals to be fully compliant with the CV-X-IF v1.0 interface. CV-X-IF Register Doc..
RTL changes:
Add
x_register_valid_oandx_register_ready_iports in:cve2_riscv_compliance.svcve2_top.svcve2_core.svcve2_id_stage.sv(
cve2_id_stage.sv) Forwardx_issue_valid_otox_register_valid_o, since their behavior is equivalent whenX_ISSUE_REGISTER_SPLIT=0(
cve2_id_stage.sv) Assignx_register_ready_ito the unused signalunused_x_register_ready. This assumes that whenX_ISSUE_REGISTER_SPLIT=0, the coprocessor can process the issue and register transactions simultaneouslyx_register_ready_i=x_issue_ready_i.(
cve2_pkg.sv) Add fixed coprocessor configuration parameterX_ISSUE_REGISTER_SPLIT=0Doc changes:
integration.rst) Update cve2 CV-X-IF interface