fix: correct error message for clan tag length (BUG-07)

[berkelmali]

Description:

The code was checking clanTag.length > MAX_CLAN_TAG_LENGTH but returning "tag_too_short". This fix corrects the error message to something more appropriate or ensures the logic matches the message.

Fix: Corrected the error message key from "tag_too_short" to "tag_too_long" when the length exceeds the maximum.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

barfires

[coderabbitai]

Walkthrough

This PR fixes a validation bug where validateClanTag returned the wrong error code when clan tags exceeded the maximum length. The validation logic was corrected, the missing English localization entry was added, and the test was updated to assert the correct error.

Changes

Clan Tag Length Validation Fix

Layer / File(s)	Summary
Clan tag validation error correction src/core/validations/username.ts, resources/lang/en.json, tests/Censor.test.ts	validateClanTag was corrected to return username.tag_too_long instead of username.tag_too_short for clan tags exceeding MAX_CLAN_TAG_LENGTH. The corresponding English localization entry and test assertion were added and updated respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A clan tag grew one char too wide,
The error code had missed the tide,
Now "too_long" sings true and clear,
With test and locale standing near! 🏷️

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: fixing an incorrect error message for clan tag length validation, with a specific bug reference.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description clearly explains the bug fix: changing the error message from 'tag_too_short' to 'tag_too_long' when clan tag length exceeds the maximum.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}