Adds map of Venice 🛶#3935
Conversation
WalkthroughAdds Venice as a new regional map to the game. The type is registered in the game enum and category system, asset data defines 11 locations with coordinates, and the generator and server integrate Venice into map builds, translations, and public playlist scheduling with frequency 6. ChangesVenice Map Onboarding
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/game/Game.ts`:
- Line 176: The change added a new map entry "Venice" in the Game map
enum/typing but no tests were added; add unit tests that cover the updated core
map typing/category behavior: create tests targeting the Game class (or the
enum/MapName type that now includes "Venice") to assert the new value exists,
that map/category resolution functions (e.g., any MapCategory or
getMapCategory/getMapByName functions) return the expected category/metadata for
"Venice", and update existing core tests that enumerate maps so they include
"Venice" to prevent regressions; ensure tests live alongside other core tests
and exercise both presence and category-resolution behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c8d7c9cc-486b-4159-8013-4a94c6057bc8
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/venice/image.pngis excluded by!**/*.pngresources/maps/venice/map.binis excluded by!**/*.binresources/maps/venice/map16x.binis excluded by!**/*.binresources/maps/venice/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (7)
map-generator/assets/maps/venice/info.jsonmap-generator/main.goresources/lang/en.jsonresources/maps/venice/manifest.jsonresources/maps/venice/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
Description:
Adds map of Venice. A relatively small map (similar land area to World) for heavy trade and lots of boating.
Because of the very low difference of elevation of the zone, terrain is instead used to show buildings.
Map source from OpenStreetMap, already credited in CREDITS.md
Very requested map, with 2 discord posts suggesting it with +15 upvotes each
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011