Prevent admins to be able to view carousel in shops#14495
Draft
chahmedejaz wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
This PR is ready for release but we need to wait for its dependent PR. Keeping it in dev test ready for now until the dependent PR is ready for release. ref: #14364 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
As part of the multiple product images roadmap, the carousel functionality is being developed before backoffice support for managing multiple images is available.
Currently, it is possible for products to have multiple images associated with them through the image settings page, even though this functionality is not intended to be available to users yet. To keep production data aligned with the current user experience, this PR:
Users can still replace an existing product image through the product list and image settings page, so there is no change to the intended image management workflow. A new image can only be added through the product list page.
What should we test?
Scenario 1 - Existing product image management
Scenario 2 - Product without an image
Scenario 3 - Migration
Release notes
Changelog Category (reviewers may add a label for the release notes):
Dependencies
Need the following PR to be merged along with this one: