Fix order cycle mail Report grouping by product and price.#14422
Open
lufafajoshua wants to merge 3 commits into
Open
Fix order cycle mail Report grouping by product and price.#14422lufafajoshua wants to merge 3 commits into
lufafajoshua wants to merge 3 commits into
Conversation
rioug
requested changes
Jun 17, 2026
…price, added tests to check whether the quantity multiplied by the unit price is equivalent to the subtotal for each line_item row in the table order-summary.
…rows in the case of different prices.
0733c63 to
f83144d
Compare
Contributor
|
Hi @lufafajoshua there's a linter error that maybe you could have a look at? |
Author
|
I think i forgot to run rubocop, let me update and push again. |
Author
|
I personally think failing tests in |
Contributor
|
You are right @lufafajoshua it's a flaky spec. Trying to get Copilot fix it in #14435 🙂 |
Contributor
|
Copilot did not manage to fix it 😄 We can move on with this PR, there will be someone reviewing it. |
rioug
approved these changes
Jun 29, 2026
rioug
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for your help 🙏
dacook
approved these changes
Jul 7, 2026
dacook
left a comment
Member
There was a problem hiding this comment.
Nice work, thank you very much!
Awaiting a manual test before it will be merged and included in a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What? Why?
In the Producer Order Cycle Mail Report, products from different orders were grouped solely by product name. As a result, when the same product appeared in multiple orders at different unit prices, the quantity multiplied by unit price did not match the displayed total price because the price differences were not reflected.
This solution groups line items by both product name and unit price. In the report, same products with identical prices continue to be integrated into a single row, while products with different prices are displayed in separate rows, ensuring that unit prices and totals are reported accurately.
What should we test?
Release notes