fix: updated syntax to match other filters#362
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
wgu-taylor-payne
left a comment
There was a problem hiding this comment.
This looks good to me. Just a couple of things to change in the changelog.
41043ac to
25e370d
Compare
bmtcril
left a comment
There was a problem hiding this comment.
Looks good to me. Is the plan to backport this and the associated platform changes to Verawood?
|
@bmtcril My plan was to to a backport in edx-platform that pointed to this new version, it loos compatible... does it some feasible to you? this is the backport PR openedx/openedx-platform#38663 Could you help me with the merge and relase please? |
felipemontoya
left a comment
There was a problem hiding this comment.
Thanks @holaontiveros. This looks good and puts the filter back on track with the others.
Description
Previous
InstructorDashboardTabsRequestedfilter didn't follow 100% the usual pattern of how the run_filter returned arguments, this updates that now the run_filter returns all the arguments that it received.Supporting information
This originated on the conversation of this filter being implemented here: openedx/openedx-platform#38499 (comment)
Deadline
None
Other information
This is virtually the same as before, it only returns two more items in the tuple to match other run_filter patterns, nothing depends on it more than the code that goes will consume it that will algo be updated after this is merged.
Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge: