feat: improve/correct handling of events and collections (backport #593)#600
feat: improve/correct handling of events and collections (backport #593)#600bradenmacdonald wants to merge 1 commit into
Conversation
* fix: don't emit COLLECTION_CHANGED when entities restored into deleted collections * test: add two tests for problematic collections events * feat: distinguish between 'restored' and 'created' entities in entities changed event (Fixes a bug with duplicate events being emitted for collection changes.) * fix: don't allow adding entities to a deleted collection (likely mistake) * test: add an even more difficult edge case * feat!: COLLECTION_CHANGED ignores changes to entity draft state, like soft deletes * build: version bump to 1.0.2 (in backport) --------- Co-authored-by: Claude <noreply@anthropic.com>
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
This backports #593 to Verawood and bumps the version to 1.0.2
Platform backport PR: openedx/openedx-platform#38695 - use this for testing once it's set to pull in this branch.