fix: update secondary text color tokens#482
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
|
Thanks for the pull request, @edschema! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
Updates Android secondary color token to achieve minimum contrast requirements and to match the iOS secondary text cleanup in openedx/openedx-app-ios#658.
Android's existing
textSecondaryvalue was too light in light mode for normal secondary metadata text. This PR updates AndroidtextSecondaryto:#3D4964#8E9BAEThe audit also found related semantic token issues where true secondary text was using
textFieldHint, placeholders needed to remain on hint styling, empty-state icons were borrowing form/border/progress tokens, and one mixed icon+text secondary row needed a non-text semantic token.Similar to the work in the iOS #658, this work required some misc cleanup.
Out of Scope
textTertiary(will need to determine whether we should add for parity with iOS)fix: add secondary color theme tokens
Change Log
textSecondarylight and dark values.emptyStateIconColorandsecondaryContentColortoAppColors.Notes
emptyStateIconColorandsecondaryContentColorintentionally share the same light and dark values astextSecondaryin this PR. Empty-state icons and mixed icon+text secondary content no longer need to use placeholder, border, divider, or progress tokens.fix: retokenize placeholder colors
Change Log
textSecondarytotextFieldHint.Notes
Actual form, search, discussion, and profile placeholders still use
textFieldHint.fix: retokenize secondary text colors
Change Log
textFieldHinttotextSecondary.0MBvalue.Notes
These rows are text-only secondary content.
fix: retokenize empty state icon colors
Change Log
emptyStateIconColor.Notes
Raw vector XML colors are unchanged; this PR only updates Compose tint callsites accepted by the audit.
fix: retokenize secondary content colors
Change Log
secondaryContentColor.Notes
State/status icons such as downloaded/success indicators remain on their existing state colors.
Tests Done
git diff --checkAI Disclosure
Codex was used to help catalog the current behavior, suggest an implementation shape, execute the fix, and generate the framework for the PR text based on Open edX guidances in the docs. Each step was manually review.