Sfincs#120
Open
hcwinsemius wants to merge 3 commits into
Open
Conversation
Collaborator
|
@hcwinsemius If you can provide me with a working example I can make some time to review early next year. @Leynse and @JoostBuitink are also already working with online coupled Wflow - SFINCS models together with USGS so it might also be useful for one of them to take a look / do the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dirk. I made a sfincs adapter, for some coupling experiments. Tim also had a case for this. Would you have time to review this? It is not very compliucated code, very similar to lisflood adapter.