fix(frontend): remove the remaining isMeTheCurrentUser references - #699
Merged
Conversation
f502ca2 dropped the definition of isMeTheCurrentUser along with the collaborator avatar block, but left seven references behind: the guards in saveCurrentSample, handleSkipSample and handleCancelSkipSample, two dependency arrays, and the disabled props on skip, cancel-skip and finish. The annotation page therefore threw ReferenceError: isMeTheCurrentUser is not defined on render. vite build does not catch this -- esbuild treats an unknown identifier as a global -- but eslint reports it as no-undef. Finishes that change: removes the leftover references, the now-unused useMe/UserAvatar/QuestionCircleOutlined imports, and the currentEditingUser destructure, which the context has never declared on this branch (that one also silenced a TS2339). Behaviour matches the intent of f502ca2: no collaboration gating, so skip, finish and save work again alongside auto-label. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f502ca2 dropped the definition of isMeTheCurrentUser along with the collaborator avatar block, but left seven references behind: the guards in saveCurrentSample, handleSkipSample and handleCancelSkipSample, two dependency arrays, and the disabled props on skip, cancel-skip and finish. The annotation page therefore threw
ReferenceError: isMeTheCurrentUser is not defined
on render. vite build does not catch this -- esbuild treats an unknown identifier as a global -- but eslint reports it as no-undef.
Finishes that change: removes the leftover references, the now-unused useMe/UserAvatar/QuestionCircleOutlined imports, and the currentEditingUser destructure, which the context has never declared on this branch (that one also silenced a TS2339).
Behaviour matches the intent of f502ca2: no collaboration gating, so skip, finish and save work again alongside auto-label.