xfeatures2d: fix out-of-bounds read in PCTSignaturesSQFD::computeQuadraticFormDistances#4173
Open
shimat wants to merge 1 commit into
Open
xfeatures2d: fix out-of-bounds read in PCTSignaturesSQFD::computeQuadraticFormDistances#4173shimat wants to merge 1 commit into
shimat wants to merge 1 commit into
Conversation
…raticFormDistances Parallel_computeSQFDs::operator() indexed mImageSignatures (a pointer to a std::vector<Mat>) as mImageSignatures[i] instead of dereferencing the vector first, i.e. (*mImageSignatures)[i]. This happened to work for i == 0 (mImageSignatures[0] is equivalent to *mImageSignatures), but for i >= 1 it read past the pointed-to vector as unallocated memory, producing undefined behavior (typically a spurious "Signature ID: N is empty!" exception once imageSignatures has 2 or more elements).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel_computeSQFDs::operator()inpct_signatures_sqfd.cppindexesmImageSignatures(aconst std::vector<Mat>*) asmImageSignatures[i]instead of(*mImageSignatures)[i]. This happens to work fori == 0, but fori >= 1it reads past the pointed-to vector as unallocated memory, which is undefined behavior and in practice throws a spuriousSignature ID: N is empty!onceimageSignatureshas 2 or more elements.Added a regression test in
test_pct_signatures_sqfd.cppthat callscomputeQuadraticFormDistanceswith 3 signatures and checks each result against a directcomputeQuadraticFormDistancecall.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.