test(ci): fix Windows skill-profile test failures#41
Merged
Conversation
- Skip activator-backed tests on Windows (Soul activator is a POSIX
bash script that spawnSync cannot execute on win32)
- Make resolveDefaultSkillTarget hermes assertion cross-platform by
mirroring path.resolve instead of hardcoding the POSIX form
Matches existing { skip: IS_WINDOWS } precedent in secure-fs.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI is red on windows-latest (node 18/20/22) while macOS + Ubuntu are green. Three skill-profile tests fail:
activateSkillProfile delegates to the Soul activator(129)resolveDefaultSkillTarget points hermes at hermes-agent/skills(131)activateSkillProfile fills hermes target from env when not given(133)Root cause
All three are POSIX-only behaviors hitting the Windows runner:
#!/usr/bin/env bashscript.spawnSynccannot execute a.shdirectly on Windows →status: null→ "activation failed (unknown)".path.join("/tmp/...", "skills"), but the impl runspath.resolvefirst, which on Windows prepends the drive (C:\tmp\...). Pure path logic, no shell.Fix (tests only — no production change)
{ skip: SKIP_POSIX_ONLY }, matching the existing{ skip: IS_WINDOWS }pattern insecure-fs.test.ts.path.resolveinstead of hardcoding the POSIX form — keeps Windows coverage for that pure-logic test.The production
resolveDefaultSkillTarget/activateSkillProfilebehavior is unchanged; the activator feature targets the user's POSIX dev environment by design.Test plan
npm testgreen on Linux — 195/195 (skips inactive off-Windows)