Feat/overwrite currency#176
Open
AftAb-25 wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for opencost-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AftAb-25
force-pushed
the
feat/overwrite-currency
branch
from
8a6577d to
0b7a673
Compare
Author
|
@ameijer I reduced the changes please review it Thank you for your time... |
ameijer
reviewed
Feb 20, 2026
| @@ -0,0 +1,46 @@ | |||
| import React, { useEffect, useState } from "react"; | |||
| @@ -0,0 +1,50 @@ | |||
| import React from "react"; | |||
| href: "/allocation", | ||
| icon: <BarChart />, | ||
| }, | ||
| { name: "Assets", href: "/assets", icon: <Storage /> }, |
AftAb-25
added a commit
to AftAb-25/opencost-ui
that referenced
this pull request
Feb 21, 2026
Per maintainer review feedback on PR opencost#176: - Remove src/pages/Assets.js - Remove src/components/AssetReport.js - Remove src/services/assets.js and assets.mock.js - Remove Assets nav item from SidebarNav.js - Remove /assets route from route.js Keeping only the DEFAULT_CURRENCY feature changes in util.js and docker-entrypoint.sh as requested.
This commit implements the Assets view to visualize data from the /assets API. It includes: - New Assets page and route - AssetService with mock data fallback - AssetReport component - Navigation updates Fixes opencost#28 Signed-off-by: AftAb-25 <aftab123215@gmail.com> Signed-off-by: aftab <aftab123215@gmail.com>
This change allows users to configure the default currency using the DEFAULT_CURRENCY environment variable, overriding the hardcoded 'USD'. Signed-off-by: aftab <aftab123215@gmail.com>
Signed-off-by: aftab <aftab123215@gmail.com>
Per maintainer review feedback on PR opencost#176: - Remove src/pages/Assets.js - Remove src/components/AssetReport.js - Remove src/services/assets.js and assets.mock.js - Remove Assets nav item from SidebarNav.js - Remove /assets route from route.js Keeping only the DEFAULT_CURRENCY feature changes in util.js and docker-entrypoint.sh as requested. Signed-off-by: aftab <aftab123215@gmail.com>
AftAb-25
force-pushed
the
feat/overwrite-currency
branch
from
2bdbc5c to
3204cbd
Compare
Author
|
@ameijer thank you for the feedback! I have reduced the changeset to focus exclusively on the DEFAULT_CURRENCY feature. I removed all the Assets-specific files, routes, and navigation items. I also fixed the DCO issues in my commits. Please let me know if there’s anything else! |
Member
|
@AftAb-25 we have updated our UI to a new 2.0 version! can you check out demo.infra.opencost.io and see if your changes can be ported over? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
What does this PR change?
*You just need to set the DEFAULT_CURRENCY environment variable when running the app. If you don't set it, it stays as USD.
How will this PR impact users?
*They no longer have to mentally convert USD prices or modify the source code themselves.