Skip to content

Make Lucius Robust to handle invalid packets like ICMPv6 over IPV4 #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonikajindal merged 1 commit into from
Jun 11, 2026
Merged

Make Lucius Robust to handle invalid packets like ICMPv6 over IPV4 #697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions dataplane/forwarding/protocol/icmp/icmp6.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,27 +170,31 @@ func (i *ICMP6) Rebuild() error {
return nil
}

i.header.Field(csumOffset, csumBytes).SetValue(0)
var sum csum16.Sum

var err error
var f []byte
if f, err = i.desc.Packet.Field(fwdpacket.NewFieldIDFromNum(fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_SRC, fwdpacket.LastField)); err != nil {
var fSrc, fDst []byte
if fSrc, err = i.desc.Packet.Field(fwdpacket.NewFieldIDFromNum(fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_SRC, fwdpacket.LastField)); err != nil {
return fmt.Errorf("icmp6: Rebuild failed: %v", err)
}
sum.Write(f)
if f, err = i.desc.Packet.Field(fwdpacket.NewFieldIDFromNum(fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST, fwdpacket.LastField)); err != nil {
if fDst, err = i.desc.Packet.Field(fwdpacket.NewFieldIDFromNum(fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST, fwdpacket.LastField)); err != nil {
return fmt.Errorf("icmp6: Rebuild failed: %v", err)
}
sum.Write(f)

if len(fSrc) != protocol.SizeIP6 || len(fDst) != protocol.SizeIP6 {
return fmt.Errorf("icmp6: Rebuild failed, invalid IP address length (src=%v, dst=%v)", len(fSrc), len(fDst))
}

i.header.Field(csumOffset, csumBytes).SetValue(0)
var sum csum16.Sum
_, _ = sum.Write(fSrc)
_, _ = sum.Write(fDst)

length := len(i.header)
f = make([]byte, protocol.SizeUint32)
f := make([]byte, protocol.SizeUint32)
binary.BigEndian.PutUint32(f, uint32(length))
sum.Write(f)
_, _ = sum.Write(f)

sum.Write([]byte{0, 0, 0, protoICMP6})
sum.Write(i.header)
_, _ = sum.Write([]byte{0, 0, 0, protoICMP6})
_, _ = sum.Write(i.header)
i.header.Field(csumOffset, csumBytes).SetValue(uint(sum))
return nil
}
Expand Down
Loading