Custom Header: Per account#59
Conversation
|
@markrosan8 FYI ^ |
|
@guruz do you have a testflight build with this? Happy to test. |
|
Will do that and ping you today/tomorrow @m8426 |
guruz
force-pushed
the
markus/per-account-http-header
branch
from
305fd4a to
0cb3ba7
Compare
Waiting for review by Apple |
|
@guruz any updates on the build? still stuck at review? |
|
Yes, just checked. This is very strange, normally Testflight reviews go through very quickly |
|
In any case, this is the link https://testflight.apple.com/join/2F5wWTGV You need to wait until apple approves v1.2.3 v.1.2.2 does not have it yet. |
|
Still nothing. Maybe I should re-create the build and push it to testflight again |
|
Hmm very odd. Maybe you can push a new build on 1.2.2? I think only the first build per version is reviewed. But I may be wrong. |
|
1.2.3 should be out now for rtesting? |
FYI @paolostivanin |
|
@guruz just tested it, it works well for nearly everything, except when you hold and click “open in collabora online” for office docs. i assume it’s using wkwebview or something for that feature, so the custom http stack doesn’t get applied there? haven’t had a chance to look through the code yet. but otherwise the headers work well with my auth proxy. great work. only thing that might be needed for some is multiple header support. |
|
I researched this and think it's not possible/feasible. I didn't actually try it. The header can only be attached to the initial request/page. (this part is not done yet) |
|
^ but I'm happy to be proven wrong. |
|
@guruz you're right that there's no way to add headers to a wkwebview session reliably across all requests i did find a more elegant solution though, we can just stick the header into a cookie and inject that into the session. it maps cleanly from header name/value to cookie name/value. it will require the edge auth proxy to accept either header or cookie values, but this should be trivial (in traefik its very simple). this is also very timely. eurooffice is supposedly removing the mobile editing gate, so mobile editing is much more usable in theory than the current desktop on mobile experience that onlyoffice forces. however, this custom header stuff is all mostly moot if mTLS is implemented. i think it sidesteps the whole "open in" issue, might be worth pushing that forwarding instead of patching the header implementation |
|
Not sure I understand it.. does the app still need changes for custom cookies or not? |
|
i think 1.2.3 can be shipped, everything else works well, and mobile office editing is not the highest priority anyways |
3 participants
@markrosan8