[Repo Assist] test(setup): expand WizardAnswerBuilder edge-case coverage#749
Conversation
Add 10 tests covering previously untested paths in WizardAnswerBuilder: - BuildWireValue(select): falls back to string when option not found - BuildWireValue(multiselect): splits comma string when options list is empty - BuildWireValue(multiselect): splits comma string when answer not in options - ReadOptions: returns empty for non-object input - ReadOptions: returns empty when 'options' property is missing - ReadOptions: returns empty when 'options' is not an array - ValueKeys: returns [] for empty-string JSON element - ValueKeys: returns single-element array for non-array scalar - ValueKeys: returns multiple elements for JSON array - ReadOptions: option without 'value' property uses label as key These paths were introduced in b90ded9 (Preserve wizard option wire values) and are exercised at runtime but had no regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs maintainer review before merge. Reviewed June 12, 2026, 6:17 PM ET / 22:17 UTC. Summary Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against ebacf0c825f9. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
🤖 This is an automated PR from Repo Assist.
Summary
Adds 10 tests covering previously untested paths in
WizardAnswerBuilder, which was introduced inb90ded9(Preserve wizard option wire values).New tests
BuildWireValue_SelectFallsBackToString_WhenNoOptionMatchselecttype returns the raw string answer when no option matchesBuildWireValue_MultiselectSplitsCommaString_WhenOptionsEmptymultiselectfalls back toSplitMultiSelectwhen there's no options listBuildWireValue_MultiselectSplitsCommaString_WhenOptionNotInListmultiselectfalls back to split whenTryResolveOptionsfailsReadOptions_ReturnsEmpty_ForNonObjectInputReadOptions_ReturnsEmpty_WhenOptionsPropertyMissing"options"property returns empty listReadOptions_ReturnsEmpty_WhenOptionsIsNotArray"options"value returns empty listValueKeys_ReturnsEmptyArray_ForEmptyStringElement[]ValueKeys_ReturnsSingleElementArray_ForNonArrayValueValueKeys_ReturnsMultipleElements_ForJsonArrayReadOptions_OptionWithoutValueUsesLabelAsKey"value"property falls back to the label as key/valueTest Status
SetupEngine tests: 256 passed, 1 failed (pre-existing:
SetupContextTests.Constructor_SetsLocalDataDirFromLocalAppDataRootEnvironmentfails on Linux due to Windows path separator — unrelated to this change; baseline is also 1 failure).Shared tests: 2214 passed, 8 failed (all pre-existing infrastructure failures — unchanged vs baseline).
Add this agentic workflows to your repo
To install this agentic workflow, run