Fix SherpaOnnx finalizer crash with DllNotFoundException

[williamwwm]

Suppress fatal crashes caused by SherpaOnnx.OfflineTts finalizer calling SherpaOnnxDestroyOfflineTts when native DLL is unavailable.

Changes:

• PiperTextToSpeechClient: gracefully handle DllNotFoundException in constructor (TTS disabled gracefully), add GC.SuppressFinalize after dispose to prevent finalizer from calling native code during GC
• App.xaml.cs: improved OnDomainUnhandledException logging for SherpaOnnx native DLL errors
• Crash prevention relies on exe.config legacyUnhandledExceptionPolicy and GC.SuppressFinalize (IsTerminating is readonly in .NET 10)

Fixes repeated crashes: System.DllNotFoundException: Unable to load DLL 'sherpa-onnx-c-api' at SherpaOnnx.OfflineTts.Finalize()

[clawsweeper]

Codex review: needs real behavior proof before merge. Reviewed June 12, 2026, 6:31 PM ET / 22:31 UTC.

Summary
Review failed before ClawSweeper could summarize the requested change.

Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path.

Review metrics: none identified.

Merge readiness
Overall: 🌊 off-meta tidepool
Proof: 🌊 off-meta tidepool
Patch quality: 🌊 off-meta tidepool
Result: rating does not apply to this item.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Risk before merge

• [P1] No close action taken because the review did not complete.

Maintainer options:

1. Decide the mitigation before merge
   Retry the Codex review after fixing the execution failure.
2. Pause or close
   Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

• [P1] Review did not complete, so no work-lane recommendation was made.

Review details

Best possible solution:

Retry the Codex review after fixing the execution failure.

Do we have a high-confidence way to reproduce the issue?

Unclear. The review failed before ClawSweeper could establish a reproduction path.

Is this the best way to solve the issue?

Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction.

AGENTS.md: unclear because the file could not be read completely.

Codex review notes: model internal, reasoning high; reviewed against ebacf0c825f9.

Label changes

Label changes:

• add rating: 🌊 off-meta tidepool: Overall readiness is 🌊 off-meta tidepool; proof is 🌊 off-meta tidepool and patch quality is 🌊 off-meta tidepool.

Label justifications:

• rating: 🌊 off-meta tidepool: Overall readiness is 🌊 off-meta tidepool; proof is 🌊 off-meta tidepool and patch quality is 🌊 off-meta tidepool.

Evidence reviewed

What I checked:

• failure reason: codex execution failed.
• codex failure detail: Codex review failed for this PR with exit 1.
• codex stderr: fix(setup): add Windows-side gateway health check to pair-operator step — Closes Step 'pair-operator' fails due to a connection error #662\n- 💬 Commented on Step 'pair-operator' fails due to a connection error #662, OpenClaw Setup Not Working #727\n\n### 2026-06-10 13:47 UTC — Run\n- 🔧 Created PR [Repo Assist] feat(canvas): F11 borderless fullscreen toggle for Canvas windows #738: feat(canvas): F11 borderless fullscreen toggle — Closes Feature request: borderless fullscreen mode for Canvas on Windows node #669\n- 💬 Commented on Feature request: borderless fullscreen mode for Canvas on Windows node #669, Reconnect / "re-approval, repair" loop connecting to a pre-existing (self-hosted) gateway over wss #696\n\n### 2026-06-10 01:23 UTC — Run\n- 🔧 Created PR [Repo Assist] fix: guard bootstrap prompt against already-configured workspaces #734: fix: guard bootstrap prompt against already-configured workspaces — Closes Tray chat repeatedly triggers first-run bootstrap prompt for an already configured workspace #729\n- 💬 Commented on Tray chat repeatedly triggers first-run bootstrap prompt for an already configured workspace #729, Config Wizard: configuring the Teams channel times out #641\n\n### 2026-06-09 13:19 UTC — Run\n- 💬 Commented on Tray chat repeatedly triggers first-run bootstrap prompt for an already configured workspace #729, Main Chat page keeps first-chat startup overlay after chat is already usable #730, PR [Repo Assist] fix(setup): cancel wizard session before disconnect to prevent stale-session errors #717\n\n### 2026-06-09 UTC — Run\n- 🏷️ Labelled OpenClaw Setup Not Working #727 with bug, needs triage\n- 🔧 Created PR [Repo Assist] refactor: consolidate WebLoginStartResult and WebLoginWaitResult into WebLoginResult #728: refactor: consolidate WebLoginStartResult and WebLoginWaitResult into WebLoginResult\n\n### 2026-06-08 01:47 UTC — Run\n- 🔧 Created PR [Repo Assist] fix(setup): cancel wizard session before disconnect to prevent stale-session retry errors #718: fix(setup): cancel wizard session before disconnect — Closes Teams SDK Channel selection can't continue #709\n- 💬 Commented on Teams SDK Channel selection can't continue #709, # [Bug]: Installer setup wizard has no Back button #688\n\n### 2026-06-07 12:50 UTC — Run\n- 🔧 Created PR [Repo Assist] fix(release): enforce minimum VC++ runtime version for onnxruntime/sherpa-onnx #712: Closes tray crash-loops on startup — bundled vc++ runtime older than onnxruntime needs #703 (superseded by maintainer Fix tray crash-loop: source x64 VC++ runtime from VS install at publish time #713)\n- 💬 Commented on tray crash-loops on startup — bundled vc++ runtime older than onnxruntime needs #703\n\n###.
• codex stdout: No stdout captured.

Likely related people:

• unknown: Codex failed before it could trace repository history. (role: review did not complete; confidence: low)

What the crustacean ranks mean

• 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
• 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
• 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
• 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
• 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
• 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
• 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.