fix: correct column position syntax in migration 380#807
Merged
RussH merged 2 commits intoJun 23, 2026
Conversation
anonymoususer72041
force-pushed
the
fix/migration-380-before-syntax
branch
from
077da7e to
625485b
Compare
Contributor
Author
|
@RussH this PR also needs to be merged before next release |
anonymoususer72041
force-pushed
the
fix/migration-380-before-syntax
branch
from
625485b to
4e62857
Compare
anonymoususer72041
force-pushed
the
fix/migration-380-before-syntax
branch
from
4e62857 to
39b17d7
Compare
RussH
requested changes
Jun 22, 2026
RussH
left a comment
RussH
left a comment
Member
There was a problem hiding this comment.
Thanks again! Please can you update this branch by merging current master into it, then I’ll re-check CI and approve/merge.
RussH
approved these changes
Jun 23, 2026
RussH
left a comment
RussH
left a comment
Member
There was a problem hiding this comment.
have merged current master, all good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the SQL syntax used in migration 380 when adding the
date_occurredcolumn to theactivitytable.The migration previously used
BEFORE date_created, which is not valid syntax forALTER TABLE ... ADD COLUMNin MySQL/MariaDB. This could cause the migration to fail when upgrading an existing installation.The column is now added
AFTER entered_by, which is valid MySQL/MariaDB syntax and preserves the intended column order becauseentered_byis directly beforedate_createdin the current schema.This keeps the migration aligned with the schema used for fresh installations.