fix: fix to enable wcslib 8 support in apple and upgrade gradle#27
Conversation
|
If you could also spruce up Is the gradle wrapper update sufficiently useful? We're nominally supporting gradle 6-8 so updating the wrapper means we'll soon lose 6-7 support, which migth hurt some contributors -- this is a more general question, but this build does have it's extra complexity so might be justified here but not everywhere |
|
I just noticed that the CI is failing, yes. I'll get on that now. The motivation to update the wrapper is to support the de-facto JDK 21 LTS. We can still support JDK 11 with this configuration, so I was thinking that the impact would be minimal. I don't see shedding JDK 1.8 support as having an impact, but maybe you know more about who relies on that still? |
|
minimum java 11 is our current goal and my reading of the landscape is that JDK11 (temurin) will be around and supported for many years. Having said that, it is also true that we've seen zero issues (afaik) running java 21 for quite a while now, so I don't think there's much of a barrier for contributors. Let's go ahead with java 21 and gradlew 8 here in wcs.git and decide soon if we can/should do that across the board. personally, I do use temurin-17-jdk to run my IDE because I didn't want the hassle of upgrading to the one that works well with 21 (just lots of annoying UI changes) |
|
ERFA needs to be built from source, and the latest is 2.0.1 which is what is now built into that |
|
The current base docker images are fedora 42 which has erfa-2.0.1 and that provides /lib64/liberfa.so.1 (don't know why it's like that). Jeff built the apple lib so maybe that one needs a rebuild? I know the linux one works because it is used in caom2 code Unlike cadc-wcs, that lib hasn't changed since forever so we've never done a version upgrade or had to support multiple versions... so maybe we don't need to do anything other than fix whatever was broken in the CI (which does not include building JNI binding libs) |
|
Good! That's done, then. |
| } | ||
| group = 'org.opencadc' | ||
| version = '2.2.0' | ||
| version = '2.3.0' |
There was a problem hiding this comment.
this can be 2.2.1 since we are only adding apple support, not a new wcslib major version
… in favour of cadc util provided
|
Thanks, done. I'm not sure why the |
Changes
publishToMavenLocal.