Add Person ORCID Organization ROR_ID

[eleftherioszisis]

Issue: openbraininstitute/obi-one#793

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
pytest	97.76% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
app/db/model.py	99.15% <100.00%> (+<0.01%)	⬆️
app/filters/organization.py	100.00% <100.00%> (ø)
app/filters/person.py	100.00% <100.00%> (ø)
app/schemas/agent.py	100.00% <100.00%> (ø)
app/utils/pydantic_validators.py	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[chr-pok]

Looking at the specs, seems like valid ORCIDs may have an "X" character as well at the last position (checksum), see https://support.orcid.org/hc/en-us/articles/360006897674-Structure-of-the-ORCID-Identifier.

Also, would be great if we could even check the checksum as additional after-validation.

[eleftherioszisis]

Fixed and added checksum validation

[chr-pok]

According to the specs, the regular expression to validate should be: ^0[a-hj-km-np-tv-z|0-9]{6}[0-9]{2}$, see https://ror.readme.io/docs/identifier.

The last two digits are also a checksum which could be validated I suppose.

[eleftherioszisis]

Fixed and added checksum validation

[jplanasc]

Other than the comments above, LGTM.

@chr-pok I can do the ORCID / ROR ID checks on obi-one side.

[eleftherioszisis]

Other than the comments above, LGTM.

@chr-pok I can do the ORCID / ROR ID checks on obi-one side.

Note that they will still be added here in the application layer.

[chr-pok]

@chr-pok I can do the ORCID / ROR ID checks on obi-one side.

Sure, I guess the earlier we check the better. But I suppose if the user provides a wrong ORCID / ROR ID, you won't be able to fetch any metadata anyway.