Skip to content

Allow users register publications #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eleftherioszisis wants to merge 5 commits into
base: main
Choose a base branch
from
+9 −4
Open

Allow users register publications #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e76fb4
Allow users register publications
eleftherioszisis Jun 29, 2026
396f835
Revert migration
eleftherioszisis Jun 29, 2026
e68fcc2
Revert unrelated changes
eleftherioszisis Jun 29, 2026
f4999bd
Revert unrelated changes
eleftherioszisis Jun 29, 2026
488425f
Add link to issue
eleftherioszisis Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/service/publication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from sqlalchemy.orm import aliased, joinedload, raiseload

from app.db.model import Person, Publication
from app.dependencies.auth import AdminContextDep
from app.dependencies.auth import AdminContextDep, UserContextDep
from app.dependencies.common import (
FacetsDep,
PaginationQuery,
Expand Down Expand Up @@ -62,7 +62,7 @@ def admin_read_one(db: SessionDep, id_: uuid.UUID) -> PublicationRead:
def create_one(
db: SessionDep,
json_model: PublicationCreate,
user_context: AdminContextDep,
user_context: UserContextDep, # See: https://github.com/openbraininstitute/obi-one/issues/867
) -> PublicationRead:
return router_create_one(
db=db,
Expand Down
9 changes: 7 additions & 2 deletions tests/test_publication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ def model_id(publication):
return publication.id


def test_create_one(client_admin, json_data):
data = assert_request(client_admin.post, url=ROUTE, json=json_data).json()
def test_create_one_admin(clients, json_data):
data = assert_request(clients.admin.post, url=ROUTE, json=json_data).json()
_assert_read_response(data, json_data)


def test_create_one_user(clients, json_data):
data = assert_request(clients.user_1.post, url=ROUTE, json=json_data).json()
_assert_read_response(data, json_data)


Expand Down