Skip to content

Allow updating measurement kinds in MeasurementAnnotation update#622

Merged
eleftherioszisis merged 3 commits into
mainfrom
measurements-update
Jun 2, 2026
Merged

Allow updating measurement kinds in MeasurementAnnotation update#622
eleftherioszisis merged 3 commits into
mainfrom
measurements-update

Conversation

@eleftherioszisis

@eleftherioszisis eleftherioszisis commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
pytest 97.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/db/model.py 99.12% <ø> (ø)
app/schemas/measurement_annotation.py 100.00% <100.00%> (ø)
app/service/measurement_annotation.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread app/service/measurement_annotation.py
Depends(_update_measurement_label_ids_on_update),
],
) -> MeasurementAnnotationRead:
def apply_operations(q):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More related to #616 rather than this PR, but if I'm not wrong most update endpoints already allow to update an entity without specifying the project context.
In this case instead it's still required, but it can be handled in a different PR.

@eleftherioszisis eleftherioszisis enabled auto-merge (squash) June 2, 2026 13:20
@eleftherioszisis eleftherioszisis merged commit a0def5c into main Jun 2, 2026
1 check passed
@eleftherioszisis eleftherioszisis deleted the measurements-update branch June 2, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants