immutability / deprecation proposal#203
Open
jdcourcol wants to merge 2 commits into
Open
Conversation
jdcourcol
requested review from
GianlucaFicarelli,
bilalesi,
eleftherioszisis,
g-bar and
mgeplf
mgeplf
reviewed
May 28, 2025
mgeplf
reviewed
May 28, 2025
mgeplf
reviewed
May 28, 2025
|
|
||
| - **Immutability**: | ||
|
|
||
| Properties changing the fundamental identity of the entity should be marked as immutable (TBD: how technically) and cannot be assigned outside of the creation of the entity. |
Contributor
There was a problem hiding this comment.
Would there be the possibility we would need to fix an immutable property?
Contributor
Author
There was a problem hiding this comment.
I would say no. We will see if that case actually happens when we cross that bridge.
| - description, name are not changing the fundamental identity of an entity. | ||
|
|
||
| - **Deletion**: | ||
| - Entities can be deleted except if they are referenced by other entities. |
Collaborator
There was a problem hiding this comment.
Is it desired/acceptable:
- to hard delete the unreferenced entities (i.e. remove them from the db)
- to hard delete any referenced asset (i.e. remove them from the db and S3)
Collaborator
There was a problem hiding this comment.
Also, does "delete" just actually delete the row, are are we doing the "normal" having a column deleleted that gets marked true? We may need both, to comply w/ right to be forgotten.
Contributor
Author
There was a problem hiding this comment.
yes, I would give the possibility to delete any unreferenced entities and assets. (no column deleted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.