Add unit tests for _openai_retry helpers (77% -> 95% coverage)#3544
Open
jluocsa wants to merge 1 commit into
Open
Add unit tests for _openai_retry helpers (77% -> 95% coverage)#3544jluocsa wants to merge 1 commit into
jluocsa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/agents/models/_openai_retry.pywas at 77% coverage: several low-level helpers (header parsing, retry-after parsing, status/error-code extraction) and a fewget_openai_retry_advicebranches were untested. This adds focused unit tests that bring the module to 95% without touching any runtime code.Changes
tests/models/test_openai_retry_helpers.pycovering:_header_lookupfor plain mappings (case-insensitive) andhttpx.Headers._get_header_valuevia theresponse_headersattribute path._parse_retry_after_msand_parse_retry_afterfor numeric, HTTP-date, negative, and invalid inputs._get_status_codeviastatus_codeandstatusattributes._get_error_codevia nested and top-levelbodymappings.get_openai_retry_advicefor theunsafe_to_replay, websocket-request,x-should-retry: false, and retry-after-only branches.Test plan
uv run pytest tests/models/test_openai_retry_helpers.pypasses (11 tests).test_model_retry.py,_openai_retry.pycoverage rises from 77% to 95%.ruff format,ruff check, andmypyare clean on the new file.