Add tests for run_demo_loop streaming, EOF, and empty-input paths#3542
Open
jluocsa wants to merge 1 commit into
Open
Add tests for run_demo_loop streaming, EOF, and empty-input paths#3542jluocsa wants to merge 1 commit into
jluocsa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_demo_loopinsrc/agents/repl.pywas only 60% covered: the streaming branch, theEOFError/KeyboardInterruptexit path, and the empty-input skip were never exercised. This adds focused tests that bring the module to 100% coverage without changing any runtime code.Changes
tests/test_repl.py: added three tests coveringtool_call_item,tool_call_output_item, andAgentUpdatedStreamEventvia a handoff),EOFError,Test plan
uv run pytest tests/test_repl.pypasses (4 tests).repl.pycoverage goes from 60% to 100%.make format,make lint, andmake typecheckare clean.