fix(dedup): extend TTL to ~5 years so upgrades never re-notify or re-appear in roundup#111
Merged
Merged
Conversation
…appear in roundup Previously sentNotifications expired after 7 days and roundup-first-seen after 14 days. A Sonarr/Radarr quality upgrade landing after those windows was treated as a brand-new item. Both windows are now ~5 years, which is effectively permanent for any realistic install lifetime. Also fixes the [DUPLICATE CHECK] log line that was checking debouncedSenders with raw SeriesId instead of the stable seriesKey, causing it to always report `has debouncer: false` for keyed series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sonarr/Radarr quality upgrades re-triggered Discord notifications and reappeared in the Weekly Roundup as new content after the dedup windows expired.
sentNotificationsexpired after 7 days,roundup-first-seenafter 14 days — an upgrade landing past those windows was treated as a brand-new item. Both maps already use stable identity keys (TMDB ID, SeriesId+S/E) that survive file replacement; the only thing broken was the TTL.Additionally, the
[DUPLICATE CHECK]log line checkeddebouncedSenderswith the rawSeriesIdinstead of the stableseriesKey, so it always reportedhas debouncer: falsefor keyed series regardless of actual state.Fix
sentNotificationsTTL extended from 7 days to ~5 yearsroundup-first-seenTTL extended from 14 days to ~5 years[DUPLICATE CHECK]log now usesseriesKeyinstead ofSeriesId