Repair gpgkey/refresh handling in pkgrepo.managed#769
Open
tacerus wants to merge 1 commit into
Open
Conversation
These were so implicitly ignored so far. Zypper command line does not support modification of "gpgkey", hence extend functions to handle it via ConfigParser and expand the tests respectively. The logic from the previous change "Fix zypper repository reconfiguration" is reverted in favor of including the missing attributes in _get_repo_info(). The gpgkey option itself was not included there, as returning "None" in case of no gpgkey might be confusing, given zypp implying a gpgkey if none is set if the baseurl matches a hardcoded list of mirrors. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Member
Author
|
while amending the tests, I also noticed that "comments" is getting ignored - I wonder how useful that feature is so I left it as a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to submit this upstream, but I notice some dependent commits are missing from 3006.x and I could not find any pending PRs for them.
What does this PR do?
These were so implicitly ignored so far.
Zypper command line does not support modification of "gpgkey", hence extend functions to handle it via ConfigParser and expand the tests respectively.
The logic from the previous change "Fix zypper repository reconfiguration" is reverted in favor of including the missing attributes in _get_repo_info(). The gpgkey option itself was not included there, as returning "None" in case of no gpgkey might be confusing, given zypp implying a gpgkey if none is set if the baseurl matches a hardcoded list of mirrors.
What issues does this PR fix or reference?
Fixes:
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes