Skip test_executor with Python 3.11 as it is flaky#733
Open
vzhestkov wants to merge 1 commit into
Open
Conversation
meaksh
reviewed
Oct 10, 2025
| self.run_function("saltutil.sync_all") | ||
|
|
||
| @pytest.mark.slow_test | ||
| @pytest.mark.skipif(sys.version_info.minor==11, reason="Flaky with Python 3.11") |
Member
There was a problem hiding this comment.
Hmmm, what about using:
Suggested change
| @pytest.mark.skipif(sys.version_info.minor==11, reason="Flaky with Python 3.11") | |
| @pytest.mark.flaky(max_runs=4) |
Contributor
Author
There was a problem hiding this comment.
Unfortunatelly it doesn't work, I tried it with 10 and it keeps failing, but as I mentioned only in case of running inside Salt Shaker environment.
vzhestkov
force-pushed
the
openSUSE/fix/3006.0/python-3.11-flaky-executor-test
branch
from
a84405a to
f1eed3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With Salt Shaker
tests.integration.minion.test_executor.py::ExecutorTest::test_executoris always failing while running in CI, but not reproducible with manual runs. For some reasonarg.pyexecutor module used in the test environment couldn't be syncronised in time, but only in case of running the test with Salt Shaker using Python 3.11.For some reason adding extra sleeps to wait for the sync to be fully completed doesn't really help and running it few times with marking as
flakyalso doesn't work and it's almost impossible to debug as it is reproducible only while triggering the job with CI.It should be safe to skip it as there is another bit more complex test test_executor_with_multijob which works fine and not flaky.
What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/26171
Previous Behavior
tests.integration.minion.test_executor.py::ExecutorTest::test_executorfails each time on running with Python 3.11 inside Salt Shaker environment.New Behavior
Flaky test skipped
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.