fix: Streamlined the process to avoid loops#4
Merged
misaka00251 merged 1 commit intoJun 14, 2026
Conversation
misaka00251
added
Type: Enhancement
misaka00251
requested changes
Jun 13, 2026
misaka00251
left a comment
misaka00251
left a comment
Member
There was a problem hiding this comment.
I think abaci_bot.Tests should also be named as abaci-bot.Tests.
1. Modified GitHubWebhookProcessor to only execute blocking logic for tagged/untagged events currently labeled "Workflow: Blocked". This fixes the infinite loop caused by "Workflow: In Review" continuously adding and removing itself. 2. When a blocked pull request synchronizes a new commit, only "Commits: Updated" is added; "Workflow: Ready For Review" is no longer automatically added. 3. Now "Commits: Updated" is only removed after the pull request author submits a comment or review. 1. Added IGitHubService.cs to allow testing the processor using a virtual GitHub service. 2. Added the xUnit test project GitHubWebhookProcessorTests.cs to cover scenarios such as infinite loops, synchronous blocking, and author/non-author cleanup of "Commits: Updated". 3. Explicitly specify the `release` command to publish `abaci-bot.csproj` to avoid solution-level publishes involving test projects and also eliminate NETSDK 1194 warnings. 4. Instantiate tag class. Co-authored-by: GPT-5.5
SteveZMTstudios
force-pushed
the
rolllock-fix
branch
from
June 13, 2026 05:30
7d0c621 to
eea62be
Compare
misaka00251
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following additional test units with the help of AI agent:
releasecommand to publishabaci-bot.csprojto avoid solution-level publishes involving test projects and also eliminate NETSDK 1194 warnings.Co-authored-by: GPT-5.5
These tests are passed: