feat: add or edit beneficiaries#24
Open
ksraj123 wants to merge 2 commits into
Open
Conversation
manigedit
reviewed
Jan 9, 2021
| { | ||
| path: 'beneficiaries/create', | ||
| component: BeneficiariesFormComponent, | ||
| data: {title: extract('Add Beneficiary')}, // think of a way to use this |
Collaborator
There was a problem hiding this comment.
@ksraj123 use of this object is intended for the iteration to achieve internationalization (multi language support).
manigedit
reviewed
Jan 9, 2021
| }); | ||
| } | ||
|
|
||
| submitBeneficiaryForm() { |
Collaborator
There was a problem hiding this comment.
@ksraj123 submitBeneficiaryForm() function has more than one exit point, let's refactor it to achieve cleaner code.
manigedit
requested changes
Jan 9, 2021
| } | ||
|
|
||
| addBeneficiary(beneficiary: BeneficiariesForm) { | ||
| beneficiary.locale = "en_GB"; |
Collaborator
There was a problem hiding this comment.
please add a comment, stating the reason for hardcoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #20
Please share feedback and suggestions. Thanks
Screenshots
Adding a new beneficiary - if successfully added then automatically redirects to beneficiaries page
Editing and existing beneficiary - Only name and transfer limit of already added beneficiary can be edited - in accordance with the API - relevant error messages - redirects to beneficiaries page if update is successful.
