Skip to content

添加UT用例 - #359

Open
openjiuwen-sync-bot[bot] wants to merge 1 commit into
openJiuwen-ai:studio-2.0-devfrom
openjiuwenai:sync/pr-1852
Open

添加UT用例#359
openjiuwen-sync-bot[bot] wants to merge 1 commit into
openJiuwen-ai:studio-2.0-devfrom
openjiuwenai:sync/pr-1852

Conversation

@openjiuwen-sync-bot

@openjiuwen-sync-bot openjiuwen-sync-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

Paired: GitHub #359GitCode !1852

What type of PR is this?

/kind

Self-checklist:(请自检,在[ ]内打上x,我们将检视你的完成情况,否则会导致pr无法合入

    • 设计:PR对应的方案是否已经经过Maintainer评审,方案检视意见是否均已答复并完成方案修改
    • 测试:PR中的代码是否已有UT/ST测试用例进行充分的覆盖,新增测试用例是否随本PR一并上库或已经上库
    • 验证:PR描述信息中是否已包含对该PR对应的Feature、Refactor、Bugfix的预期目标达成情况的详细验证结果描述
    • 接口:是否涉及对外接口变更,相应变更已得到接口评审组织的通过,API对应的注释信息已经刷新正确
    • 文档:是否涉及官网文档修改,如果涉及请及时提交资料到Doc仓

Linked Closing Issues:

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@openjiuwen-collaboration-bot

openjiuwen-collaboration-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

head_sha: 5321cb66cd3822ab063f543f1a06fa068395ce47

变更摘要

该 PR 标题为「添加UT用例」,核心工作是为 controller 相关模块补充单元测试,覆盖此前几处修复的回归场景;同时包含一处前端 delete-refs-modal 的小改动。测试集中在 Python 侧(agent-runtime/tests/unit_tests/controller/)和 Java 侧(ControllerManagementServiceTest.java),分别验证 max_agent_calls 边界判断、parse_llm_response 正则提取、恢复模式下用户输入提取,以及 recordRefModel / recordRefWorkflow / recordRefSubController / recordRefAgent 的映射落库逻辑。

主要改动

  • 新增 controller 测试公共 fixtures 与路径修正conftest.py 手动将 packages/ 下的 common_utilsstoragemodel_service 加入 sys.path,以解决 pytest AssertionRewritingHook 覆盖 editable finder 导致的可编辑包导入失败问题。
  • 新增 max_agent_calls 边界判断测试test_control_agent_boundary.py 验证 _select_agent_with_cycle_check>= 改为 > 后的行为,即「恰好达到最大次数」应正常调用 select_agent 而不触发循环检测。
  • 新增 ExtractParams.parse_llm_response 正则回归测试test_extract_params.py 覆盖 markdown 代码块提取、纯 JSON、null/true/false 处理、空字符串与非法 JSON 等边界,重点验证正则补齐 ``` 边界后的解析修复。
  • 新增恢复模式输入提取测试test_sub_workflow_resume.pytest_workflow_wrapper_resume.py 分别验证 _extract_from_interactive_input_extract_resume_queryInteractiveInputuser_inputs / raw_inputs 中提取最新用户回复及其优先级、回退逻辑。
  • 新增 Java 侧 ControllerManagementService 引用映射测试:在 ControllerManagementServiceTest.java 中补充 recordRefModel(删除/插入/更新映射)、recordRefWorkflowrecordRefSubControllerrecordRefAgent 的测试,断言生成的 MappingEntityappTypeCommonConstant.CONTROLLER
  • 修复删除引用弹窗确认逻辑delete-refs-modal.component.tsonConfirmthis.deleteVal === 'DELETE' 改为 this.deleteVal.toUpperCase() === 'DELETE',使确认关键字判断不再区分大小写。

@openjiuwen-collaboration-bot

openjiuwen-collaboration-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

head_sha: bfb8841136a5caefffb4ff05702ac704b8c758d9

代码审查

✅ 未发现问题

@openjiuwen-collaboration-bot

Copy link
Copy Markdown

head_sha: bfb8841136a5caefffb4ff05702ac704b8c758d9

TASK STATUS DETAILS
CodeCheck ❌FAILED Click here
AntiPoison ✅SUCCESS Click here
Software Composition Analysis ✅SUCCESS Click here
Npm Build ✅SUCCESS See CHECK tab
Ruff Check ✅SUCCESS See CHECK tab
UT测试 ✅SUCCESS 点此跳转

@openjiuwen-collaboration-bot

Copy link
Copy Markdown

head_sha: bfb8841136a5caefffb4ff05702ac704b8c758d9

TASK STATUS DETAILS
CodeCheck ❌FAILED Click here
AntiPoison ✅SUCCESS Click here
Software Composition Analysis ✅SUCCESS Click here
Npm Build ✅SUCCESS See CHECK tab
Ruff Check ✅SUCCESS See CHECK tab
UT测试 ✅SUCCESS 点此跳转

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants