fix(llm): forward thinking on Anthropic requests and drop sampling wi… - #483
Open
renanalmd wants to merge 1 commit into
Open
fix(llm): forward thinking on Anthropic requests and drop sampling wi…#483renanalmd wants to merge 1 commit into
renanalmd wants to merge 1 commit into
Conversation
…th it _build_anthropic_params rebuilds its payload from an explicit key set and dropped thinking. Forward thinking, size max_tokens for the budget plus answer headroom, and omit sampling knobs when thinking is present.
|
head_sha: 变更摘要此 PR 修复了 主要改动
|
|
head_sha: 代码审查✅ 未发现问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired: GitHub #483 ↔ GitCode !2297
What type of PR is this?
/kind bug
What does this PR do / why do we need it:
_build_anthropic_paramsrebuilds its payload from an explicit key set and droppedthinking.thinking, sizemax_tokensfor the budget plus answer headroom, and omit sampling knobs when thinking is present.Which issue(s) this PR fixes:
Fixes openJiuwen-ai/jiuwenswarm#2710
What scenarios were tested, and what were the verification results(Function, performance, reliability, etc.):
63 passedintests/unit_tests/core/foundation/llm/test_anthropic_model_client.pythinkingwithbudget_tokens.max_tokenswhen the budget would leave less than 4096 answer tokens.Self-checklist:(Please check carefully,and mark an x in the [] brackets. We will review your completion status.)