Revert: Make plugin-management repositories in the init script configurable (#59)#63
Merged
Merged
Conversation
…urable (open-toast#59)" This reverts commit 45525c5.
ogolberg
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #59.
extension.pluginRepositories.getOrElse(emptyList())is read inside thetasks.named<Test>(\"test\") { ... }configuration block. When the test task gets realized eagerly (e.g. by `kotlin-dsl` configuring its test source set during plugin application), the extension'sListPropertyhasn't been mutated by the user's `configure { pluginRepositories.add(...) }` block yet, so we read an empty list, never set the system property, and the init script falls back togradlePluginPortal().Downstream configured
testkitTests.pluginRepositoriesand the resulting init script still containedgradlePluginPortal()instead of the configured URL.A correct implementation might defer the read to task execution time using
jvmArgumentProviders.add { ... }orProvider.map { ... }.