Skip to content

fix: show file path in textlint CI failures and fix existing violation#3928

Open
lmolkova with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-texlint-error
Open

fix: show file path in textlint CI failures and fix existing violation#3928
lmolkova with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-texlint-error

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

make textlint format=github uses textlint's --format github formatter, which emits GitHub Actions annotations. In the CI log these render as bare error messages with no file context, making failures like Error: Incorrect term: "id", use "ID" instead impossible to locate without digging through annotations.

Change

  • Remove format=github from the textlint CI step so the default formatter runs, which prints the full file path, line, and column directly in the log:
/path/to/.chloggen/web_vital-attributes.yaml
  13:69  ✓ error  Incorrect term: "id", use "ID" instead  terminology

Copilot AI requested review from Copilot and removed request for Copilot July 23, 2026 18:27
Copilot AI linked an issue Jul 23, 2026 that may be closed by this pull request
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 23, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-25 15:08:33 UTC.

  • Waiting on: Reviewers
  • Next step: Review the latest changes.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

Copilot AI requested review from Copilot and removed request for Copilot July 23, 2026 18:30
Copilot AI changed the title [WIP] Fix texlint to show error location for incorrect terms fix: show file path in textlint CI failures Jul 23, 2026
Copilot AI requested a review from lmolkova July 23, 2026 18:30
@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Jul 23, 2026
@lmolkova
lmolkova marked this pull request as ready for review July 23, 2026 18:32
@lmolkova
lmolkova requested review from a team as code owners July 23, 2026 18:32
Copilot AI review requested due to automatic review settings July 23, 2026 18:32
@lmolkova

Copy link
Copy Markdown
Member
Run make textlint
semantic-conventions@ /home/runner/work/semantic-conventions/semantic-conventions
├─┬ textlint-filter-rule-allowlist@4.0.0
│ └── textlint@15.7.1 deduped
├─┬ textlint-rule-period-in-header@0.1.2
│ └── textlint@15.7.1 deduped
└── textlint@15.7.1


/home/runner/work/semantic-conventions/semantic-conventions/.chloggen/web_vital-attributes.yaml
  13:69  ✓ error  Incorrect term: “id”, use “ID” instead  terminology

✖ 1 problem (1 error, 0 warnings, 0 infos)
✓ 1 fixable problem.
Try to run: $ textlint --fix [file]
make: *** [Makefile:115: textlint] Error 1

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the textlint CI workflow to make failures easier to debug by ensuring the log output includes file/line/column context (instead of relying on GitHub Actions annotations from the --format github formatter).

Changes:

  • Removed format=github from the textlint CI step so make textlint uses textlint’s default formatter (which prints file path + location in logs).

@lmolkova

Copy link
Copy Markdown
Member

@copilot now go fix the violation and update title to say that we fixed it

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@copilot now go fix the violation and update title to say that we fixed it

Fixed the violation in .chloggen/web_vital-attributes.yaml — changed id to ID on line 13. Textlint now passes cleanly. The PR title update is outside my scope here (the title is set at the PR level), but please feel free to update it to something like "fix: show file path in textlint CI failures and fix id→ID terminology violation".

Copilot AI requested a review from lmolkova July 23, 2026 18:36
@lmolkova lmolkova changed the title fix: show file path in textlint CI failures fix: show file path in textlint CI failures and fix existing violation Jul 23, 2026
@lmolkova lmolkova moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Jul 23, 2026

@thompson-tomo thompson-tomo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually removes functionality. Currently the filepath is used to report it as an annotation
image

This enables a reviewer to see directly on a changed file the issues hence is easier then scrolling through logs.

image

Also the fix is not correct as id represents a field name which is lowercased and not upper, to fix either chang config aka #3929 to ignore the directory or #3930 which uses backticks to indicate it is a field/attribute name.

@github-project-automation github-project-automation Bot moved this from Needs More Approval to Blocked in Semantic Conventions Triage Jul 24, 2026
@lmolkova

lmolkova commented Jul 24, 2026

Copy link
Copy Markdown
Member

Annotation is not as helpful as ci log, much harder to see regardless is you're a human or an agent. It's nice to have, but not at a cost of not having filename in the plain text.

Especially problematic when error is on the file that's not in the PR - current problem.

@thompson-tomo

Copy link
Copy Markdown
Contributor

Current problem is an edge case which only occurs during merge process and files changing before merge.

I am not following how it is harder on humans for issues going forward as for everyone reviewing the files via the changes tab can see issues on the file inline that way they have max context. They can also see them at the top of the check which is where they go to get their logs.

It should be easier for agents as now the check itself provides a list of errors & their location.

@lmolkova

Copy link
Copy Markdown
Member

Edge case maybe, it's not the last time it happens - textlint will get new rules and they'll fail in random places.

There literally no information when it does on where the problem is

Screenshot_20260723-190553

I'm going to repeat that path on log is a must, github comment is nice to have. Going through all github comments is much harder than looking into ci logs.

@thompson-tomo

thompson-tomo commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

It's right there in the annotations section at the top of the screen. Annotations are similar to comments but are different.

Also all rules are implemented as npm packages so we need to explicitly enable the additional npm package we have added to our project for it to result in a difference in behaviour.

@lmolkova

lmolkova commented Jul 24, 2026

Copy link
Copy Markdown
Member

It's wonderful to see annotations.
It's not wonderful that they show up collapsed - that's probably why I never look at them. Thanks for educating me they show up there.
It's not acceptable that they turn off file locations in the CI logs.


yamllint for example, does it well: https://github.com/open-telemetry/semantic-conventions/actions/runs/29971521674/job/89094348620?pr=3919

image

annotations and CI logs are not mutually exclusive. If textlint does it right, I'll be happy to enable github format.

@lmolkova lmolkova moved this from Blocked to Needs More Approval in Semantic Conventions Triage Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:browser breaking Skip Changelog Label to skip the changelog check

Projects

Status: Needs More Approval

Development

Successfully merging this pull request may close these issues.

texlint does not tell where the problem is

5 participants