Clarify server.address | port on RPC server, use recommended requirement level on server spans and opt-in on server metric#3919
Open
lmolkova wants to merge 7 commits into
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-25 10:12:31 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RPC semantic conventions to better align server.address / server.port on RPC server spans with the HTTP server guidance, including documenting how to populate these attributes for gRPC.
Changes:
- Updates the RPC model to recommend
server.addresson server spans (when available) and adds gRPC-specific population guidance based on HTTP/2 authority information. - Adjusts RPC and gRPC documentation to reflect the updated requirement levels and guidance for
server.address/server.port. - Reorders/renumbers the affected attribute table rows and footnotes to match the updated model.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
model/rpc/spans.yaml |
Adds/updates server.address/server.port guidance for generic RPC server spans and gRPC server spans. |
docs/rpc/rpc-spans.md |
Updates the rendered RPC server span attribute table and footnotes to reflect the new model guidance. |
docs/rpc/grpc.md |
Updates the rendered gRPC server span attribute table and footnotes to reflect the new model guidance. |
Comments suppressed due to low confidence (1)
model/rpc/spans.yaml:280
- To align with the HTTP server conventions,
server.porton gRPC server spans should remain conditionally required when available (and only whenserver.addressis set), rather than merely recommended. Relaxing this requirement makes gRPC inconsistent with the generalserver.portguidance and with the stated goal of aligning with HTTP server semantics.
requirement_level:
recommended: If `server.address` is set.
trask
approved these changes
Jul 23, 2026
server.address | port on RPC serverserver.address | port on RPC server, user 1recommended requirement level on server spans and opt-in` on server metric
server.address | port on RPC server, user 1recommended requirement level on server spans and opt-in` on server metricserver.address | port on RPC server, use recommended requirement level on server spans and opt-in on server metric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3784
Changes
Align
server.address | portwith HTTP serverAdd section to gRPC server that it comes from
:authority(not always exposed in public APIs - c++, java, .net.Given it's exposed as public API, it seems to have enough significance to be captured on telemetry.
Merge requirement checklist
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩