[k8s] Change memory.usage from gauge to updowncounter#3889
Merged
Conversation
ChrsMark
force-pushed
the
fix_mem_usage_instr
branch
from
July 14, 2026 07:36
f13445e to
eb3a739
Compare
7 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Kubernetes and container semantic convention metric definitions to align memory usage metrics with the intended instrument type (UpDownCounter), and propagates that change into the generated registry docs and migration guidance.
Changes:
- Switch
k8s.pod.memory.usageandk8s.node.memory.usageinstrument fromgaugetoupdowncounterin the model. - Switch
container.memory.usageinstrument toupdowncounterin the model and update generated docs accordingly. - Add a non-normative migration note plus a changelog entry for the breaking change.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| model/k8s/metrics.yaml | Changes pod/node memory usage metric instrument to updowncounter. |
| model/container/metrics.yaml | Changes container memory usage metric instrument to updowncounter. |
| docs/system/k8s-metrics.md | Updates generated metric table instrument types for k8s pod/node memory usage. |
| docs/system/container-metrics.md | Updates generated metric table instrument type for container memory usage. |
| docs/non-normative/k8s-migration.md | Adds migration guidance for the instrument-type change (with minor doc fixes needed). |
| .chloggen/fix_mem_usage_instr.yaml | Adds breaking-change changelog entry (needs accuracy/traceability fixes). |
dashpole
approved these changes
Jul 14, 2026
TylerHelmuth
approved these changes
Jul 14, 2026
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
fix_mem_usage_instr
branch
from
July 16, 2026 11:55
685512a to
70886e8
Compare
ChrsMark
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
joaopgrassi
approved these changes
Jul 17, 2026
lmolkova
enabled auto-merge
July 17, 2026 18:04
lmolkova
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
github-project-automation
Bot
moved this from Approved by K8s SIG
to Done
in K8s SemConv SIG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As highlighted at #3883 (review) this changes the instrument type to updowncounter for the following metrics:
container.memory.usagefrom counter to updowncounterk8s.pod.memory.usagefrom gauge to updowncounterk8s.node.memory.usagefrom gauge to updowncounterImportant
Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.
Merge requirement checklist
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩