Skip to content

feat: add service.instance.cost_center.id attribute#3866

Open
Ayushi-12 wants to merge 1 commit into
open-telemetry:mainfrom
Ayushi-12:clean-takeover-cloudevents
Open

feat: add service.instance.cost_center.id attribute#3866
Ayushi-12 wants to merge 1 commit into
open-telemetry:mainfrom
Ayushi-12:clean-takeover-cloudevents

Conversation

@Ayushi-12

@Ayushi-12 Ayushi-12 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #3754

Changes

This PR takes over and refreshes #3756. It adds the service.instance.cost_center.id attribute and addresses previous feedback.

  • Added service.instance.cost_center.id to the registry.
  • Updated service.instance entity.
  • Added changelog entry.
  • Regenerated all documentation via make fix.

Supersedes #3756. Fixes #3754.

Important

Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Links to prototypes or existing instrumentations (when adding or changing conventions)
  • Disclose AI usage, see OTel GenAI policy:
    • no AI used
    • AI-assisted
    • bulk AI-generated
  • I have the experience and knowledge necessary to understand, review, and validate all content in this PR.1

Footnotes

  1. Yes, I can answer maintainer questions about the content of this PR without using AI.

@Ayushi-12
Ayushi-12 requested review from a team as code owners July 9, 2026 06:27
@github-actions github-actions Bot added enhancement New feature or request area:service labels Jul 9, 2026
@Ayushi-12
Ayushi-12 force-pushed the clean-takeover-cloudevents branch 2 times, most recently from c5fc4e2 to 8e7200d Compare July 9, 2026 06:32
@Ayushi-12
Ayushi-12 force-pushed the clean-takeover-cloudevents branch from 8e7200d to 248e8b0 Compare July 9, 2026 06:40
consumers MAY use this attribute to optimize telemetry collection
or improve user experience.
examples: ["critical", "high", "medium", "low"]
- id: service.instance.cost_center.id

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really an id? Was name considered? I wonder if that's the best way forward. Sounds weird to call it id when I imagine usually we will have the name of the cost center.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could likely have both.
cost_center IDs are also relevant as they represent a direct mapping to some account ID of a cloud provider.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. To me name sounds the most likely thing we will see. I wonder if we should discuss it more, find more examples. I particularly find id for cost center a bit unknown of. I always see it as a "human-friendly" string, usually the name of a department or smt.

Having both is fine, I just then think we need to make sure it's clear when both/or not should be populated.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this over slack. I like the idea of having both, but I would want more opinions for narrowing down the definition.

@joaopgrassi joaopgrassi moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Jul 9, 2026
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-25 16:56:13 UTC.

  • Waiting on: Author
  • Next step: Address or respond to 1 review feedback item:
    • Inline threads: 1
    • For each item, reply to move the discussion forward, e.g. link to the commit that addresses it, explain why no change is needed, or ask a follow-up question.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. If you believe this pull request is incorrectly routed as waiting on the author, comment /dashboard route:reviewers to route it from waiting on the author to waiting on reviewers. If the last refreshed time above predates your latest reply or push, the dashboard hasn't processed it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:service enhancement New feature or request

Projects

Status: Awaiting codeowners approval

Development

Successfully merging this pull request may close these issues.

Proposal: Add service.instance.cost_center attribute

2 participants