feat: add service.instance.cost_center.id attribute#3866
Conversation
c5fc4e2 to
8e7200d
Compare
8e7200d to
248e8b0
Compare
| consumers MAY use this attribute to optimize telemetry collection | ||
| or improve user experience. | ||
| examples: ["critical", "high", "medium", "low"] | ||
| - id: service.instance.cost_center.id |
There was a problem hiding this comment.
Is it really an id? Was name considered? I wonder if that's the best way forward. Sounds weird to call it id when I imagine usually we will have the name of the cost center.
There was a problem hiding this comment.
We could likely have both.
cost_center IDs are also relevant as they represent a direct mapping to some account ID of a cloud provider.
There was a problem hiding this comment.
I see. To me name sounds the most likely thing we will see. I wonder if we should discuss it more, find more examples. I particularly find id for cost center a bit unknown of. I always see it as a "human-friendly" string, usually the name of a department or smt.
Having both is fine, I just then think we need to make sure it's clear when both/or not should be populated.
There was a problem hiding this comment.
In Dynatrace we have for example this guidance: https://docs.dynatrace.com/docs/manage-your-costs/allocate/plan-and-set-up#choose-an-allocation-model
There was a problem hiding this comment.
Let's discuss this over slack. I like the idea of having both, but I would want more opinions for narrowing down the definition.
Pull request dashboard statusStatus last refreshed: 2026-07-25 16:56:13 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. If you believe this pull request is incorrectly routed as waiting on the author, comment |
Fixes #3754
Changes
This PR takes over and refreshes #3756. It adds the
service.instance.cost_center.idattribute and addresses previous feedback.service.instance.cost_center.idto the registry.service.instanceentity.make fix.Supersedes #3756. Fixes #3754.
Important
Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.
Merge requirement checklist
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩