Skip to content

[chore] switch weaver to builtin attribute filter#3836

Open
thompson-tomo wants to merge 11 commits into
open-telemetry:mainfrom
thompson-tomo:chore/splitDeprecateAttributes
Open

[chore] switch weaver to builtin attribute filter#3836
thompson-tomo wants to merge 11 commits into
open-telemetry:mainfrom
thompson-tomo:chore/splitDeprecateAttributes

Conversation

@thompson-tomo

@thompson-tomo thompson-tomo commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Progresses #3808

Unblocks #3827

Changes

we have switched to the builtin attribute group filter to enable v2 to work without changes to docs.

To reduce diff, this pr uses jinja to create the deprecated attribute groups in the registry pages and not rely on attribute groups. The only viable alternative considering v2 syntax, would be to publish lots of attribute groups. However i don't think that is the best approach as it bloats our published artifact etc. All doc changes have been driven by updating the jinja and no manual changes to the docs were done.

This topic needs to be resolved before any v2 switch.

Important

Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Links to prototypes or existing instrumentations (when adding or changing conventions)
  • Disclose AI usage, see OTel GenAI policy:
    • no AI used
    • AI-assisted
    • bulk AI-generated
  • I have the experience and knowledge necessary to understand, review, and validate all content in this PR.1

Footnotes

  1. Yes, I can answer maintainer questions about the content of this PR without using AI.

@thompson-tomo thompson-tomo changed the title chore: split deprecated attributes [chore] split deprecated attributes Jun 30, 2026
@thompson-tomo
thompson-tomo force-pushed the chore/splitDeprecateAttributes branch 4 times, most recently from a4c0e35 to 8aeb5e1 Compare June 30, 2026 02:38
@thompson-tomo
thompson-tomo force-pushed the chore/splitDeprecateAttributes branch from 8aeb5e1 to 2a3a652 Compare June 30, 2026 02:51
@thompson-tomo
thompson-tomo marked this pull request as ready for review June 30, 2026 03:05
@thompson-tomo
thompson-tomo requested review from a team as code owners June 30, 2026 03:05
Comment thread docs/registry/attributes/README.md

## Exception Attributes

This document defines the shared attributes used to report a single exception associated with a span or log.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meaningful/useful?


## Host Attributes

A host is defined as a computing instance. For example, physical servers, virtual machines, switches or disk array.

@thompson-tomo thompson-tomo Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meaningful/useful? Or is the entity sufficient.


## Pprof specific attributes for the Profiling signal

Attributes specific to pprof that help convert from pprof to Profiling signal.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meaningful/useful?


## Profile Frame Attributes

Describes the origin of a single frame in a Profile.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps an attribute group?


## Thread Attributes

These attributes may be used for any operation to store information about a thread that started a span.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meaningful/useful?

@thompson-tomo thompson-tomo changed the title [chore] split deprecated attributes [chore] switch to builtin attribute filter Jun 30, 2026
@thompson-tomo
thompson-tomo marked this pull request as draft June 30, 2026 17:33
@thompson-tomo
thompson-tomo force-pushed the chore/splitDeprecateAttributes branch 7 times, most recently from dd79428 to 304349c Compare July 1, 2026 03:49
@thompson-tomo
thompson-tomo force-pushed the chore/splitDeprecateAttributes branch from 304349c to 570eef5 Compare July 1, 2026 04:03
@thompson-tomo
thompson-tomo marked this pull request as ready for review July 1, 2026 04:18
@thompson-tomo
thompson-tomo force-pushed the chore/splitDeprecateAttributes branch 2 times, most recently from a174d30 to 61d6d57 Compare July 2, 2026 01:49
@thompson-tomo
thompson-tomo force-pushed the chore/splitDeprecateAttributes branch 5 times, most recently from 1ddf54c to 1c35b39 Compare July 2, 2026 03:11
@thompson-tomo thompson-tomo mentioned this pull request Jul 2, 2026
13 tasks
@thompson-tomo
thompson-tomo force-pushed the chore/splitDeprecateAttributes branch from a40ef01 to d5b6dbd Compare July 3, 2026 02:20
@thompson-tomo thompson-tomo changed the title [chore] switch to builtin attribute filter [chore] switch weaver to builtin attribute filter Jul 3, 2026
@github-actions

Copy link
Copy Markdown

This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days.

@github-actions github-actions Bot added the Stale label Jul 18, 2026
Copilot AI review requested due to automatic review settings July 18, 2026 04:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the registry markdown generation pipeline to rely on Weaver’s built-in semconv_grouped_attributes filter (supporting the schema v2 migration work) while still producing registry pages for deprecated/legacy namespaces via Jinja-driven rendering, and regenerates the affected docs output accordingly.

Changes:

  • Switched registry template inputs from a custom jq attribute-group query to Weaver’s built-in semconv_grouped_attributes (with exclusions for selected namespaces).
  • Updated Jinja templates to separate deprecated attributes into collapsible <details> sections and adjust namespace/title mapping.
  • Regenerated registry markdown pages and updated cross-doc snippets where deprecated attributes are now grouped under a dedicated section.

Reviewed changes

Copilot reviewed 86 out of 86 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
templates/registry/markdown/weaver.yaml Switches registry generation filters to semconv_grouped_attributes and adds namespace/title maps/aliases.
templates/registry/markdown/attributes_readme.md.j2 Updates attribute registry README generation to use root_namespace-based bundles and aliasing.
templates/registry/markdown/attribute_table.j2 Splits deprecated vs non-deprecated attributes and renders deprecated attributes in a <details> section.
templates/registry/markdown/attribute_namespace.md.j2 Updates per-namespace registry pages to be root_namespace/attributes-driven and append deprecated attributes via shared macro.
templates/registry/markdown/attribute_macros.j2 Updates attribute linking behavior for registry references.
templates/registry/markdown/attribute_group_namespace.md.j2 New template to keep attribute-group-based pages for excluded namespaces.
docs/registry/attributes/README.md Regenerated attribute registry index with new namespace grouping/aliases.
docs/registry/attributes/android.md Regenerated Android attribute registry page (deprecated section rendered via <details>).
docs/registry/attributes/app.md Regenerated Application attribute registry page.
docs/registry/attributes/aspnetcore.md Regenerated ASP.NET Core attribute registry page.
docs/registry/attributes/az.md New deprecated-namespace page for az.* attributes.
docs/registry/attributes/azure.md Regenerated Azure attribute registry page (content regrouped).
docs/registry/attributes/browser.md Regenerated Browser attribute registry page.
docs/registry/attributes/cassandra.md Regenerated Cassandra attribute registry page.
docs/registry/attributes/cloud.md Regenerated Cloud attribute registry page.
docs/registry/attributes/cloudevents.md Regenerated CloudEvents attribute registry page.
docs/registry/attributes/cloudfoundry.md Regenerated CloudFoundry attribute registry page.
docs/registry/attributes/code.md Regenerated Code attribute registry page (deprecated section via <details>).
docs/registry/attributes/container.md Regenerated Container attribute registry page (deprecated section via <details>).
docs/registry/attributes/cpu.md Regenerated CPU attribute registry page.
docs/registry/attributes/cpython.md Regenerated CPython attribute registry page.
docs/registry/attributes/db.md Regenerated Database attribute registry page (deprecated attributes moved into <details>).
docs/registry/attributes/deployment.md Regenerated Deployment attribute registry page (deprecated section via <details>).
docs/registry/attributes/device.md Regenerated Device attribute registry page.
docs/registry/attributes/disk.md Regenerated Disk attribute registry page.
docs/registry/attributes/dns.md Regenerated DNS attribute registry page.
docs/registry/attributes/dotnet.md Regenerated .NET attribute registry page.
docs/registry/attributes/elasticsearch.md Regenerated Elasticsearch attribute registry page.
docs/registry/attributes/enduser.md Regenerated Enduser attribute registry page (deprecated section via <details>).
docs/registry/attributes/error.md Regenerated Error attribute registry page (deprecated section via <details>).
docs/registry/attributes/event.md Regenerated Event attribute registry page (deprecated-only content via <details>).
docs/registry/attributes/exception.md Regenerated Exception attribute registry page (deprecated section via <details>).
docs/registry/attributes/faas.md Regenerated FaaS attribute registry page.
docs/registry/attributes/feature-flag.md Regenerated Feature Flag attribute registry page (deprecated section via <details>).
docs/registry/attributes/file.md Regenerated File attribute registry page (lock attributes merged into main table).
docs/registry/attributes/go.md Regenerated Go attribute registry page.
docs/registry/attributes/graphql.md Regenerated GraphQL attribute registry page.
docs/registry/attributes/hardware.md Regenerated Hardware attribute registry page.
docs/registry/attributes/heroku.md Regenerated Heroku attribute registry page.
docs/registry/attributes/host.md Regenerated Host attribute registry page.
docs/registry/attributes/http.md Regenerated HTTP attribute registry page (deprecated section via <details>).
docs/registry/attributes/ios.md Regenerated iOS attribute registry page (deprecated section via <details>).
docs/registry/attributes/jsonrpc.md Regenerated JSON-RPC attribute registry page.
docs/registry/attributes/jvm.md Regenerated JVM attribute registry page.
docs/registry/attributes/k8s.md Regenerated Kubernetes attribute registry page (deprecated section via <details>).
docs/registry/attributes/linux.md Regenerated Linux attribute registry page (deprecated-only content via <details>).
docs/registry/attributes/log.md Regenerated Log attribute registry page (sections consolidated).
docs/registry/attributes/mainframe.md Regenerated Mainframe attribute registry page.
docs/registry/attributes/message.md New deprecated-namespace page for message.* attributes.
docs/registry/attributes/messaging.md Regenerated Messaging attribute registry page (sections consolidated; deprecated section via <details>).
docs/registry/attributes/net.md New deprecated-namespace page for net.* attributes.
docs/registry/attributes/network.md Regenerated Network attribute registry page (deprecated net.* moved out).
docs/registry/attributes/nfs.md Regenerated NFS attribute registry page.
docs/registry/attributes/nodejs.md Regenerated Node.js attribute registry page.
docs/registry/attributes/oci.md Regenerated OCI attribute registry page.
docs/registry/attributes/onc-rpc.md Regenerated ONC RPC attribute registry page.
docs/registry/attributes/openshift.md Regenerated Openshift attribute registry page.
docs/registry/attributes/opentracing.md Regenerated OpenTracing attribute registry page.
docs/registry/attributes/oracle-cloud.md Regenerated Oracle Cloud attribute registry page.
docs/registry/attributes/oracle.md Regenerated Oracle attribute registry page (renamed from OracleDB content).
docs/registry/attributes/os.md Regenerated Operating System attribute registry page.
docs/registry/attributes/otel.md Regenerated OTel attribute registry page (sections consolidated; deprecated section via <details>).
docs/registry/attributes/other.md New deprecated-namespace page for un-namespaced legacy attributes (e.g., state).
docs/registry/attributes/peer.md Regenerated Peer attribute registry page (deprecated-only content via <details>).
docs/registry/attributes/pool.md New deprecated-namespace page for legacy pool attributes.
docs/registry/attributes/pprof.md Regenerated Pprof attribute registry page.
docs/registry/attributes/process.md Regenerated Process attribute registry page (deprecated section via <details>; Linux cgroup attribute moved into main list).
docs/registry/attributes/profile.md Regenerated Profile attribute registry page.
docs/registry/attributes/rpc.md Regenerated RPC attribute registry page (deprecated section via <details>; message.* moved out).
docs/registry/attributes/service.md Regenerated Service attribute registry page (peer-service attributes moved into main list).
docs/registry/attributes/signalr.md Regenerated SignalR attribute registry page.
docs/registry/attributes/system.md Regenerated System attribute registry page (sections consolidated; deprecated section via <details>).
docs/registry/attributes/telemetry.md Regenerated Telemetry attribute registry page.
docs/registry/attributes/tls.md Regenerated TLS attribute registry page (deprecated section via <details>).
docs/registry/attributes/url.md Regenerated URL attribute registry page.
docs/registry/attributes/user-agent.md Regenerated User-agent attribute registry page (sections consolidated).
docs/registry/attributes/user.md Regenerated User attribute registry page.
docs/registry/attributes/v8js.md Regenerated V8js attribute registry page.
docs/registry/attributes/webengine.md Regenerated Webengine attribute registry page.
docs/registry/attributes/zos.md Regenerated zOS attribute registry page.
docs/README.md Adds redirect from the old oracledb registry route to oracle.
docs/cloud-providers/aws-sdk.md Regenerated snippet output to move deprecated attributes into a <details> block.
docs/db/dynamodb.md Regenerated snippets to move deprecated attributes into a <details> block (repeated sections).
docs/db/oracledb.md Updates registry links from oracledb attributes page to the new oracle page.
docs/exceptions/exceptions-spans.md Moves deprecated exception attribute into a <details> block.
docs/object-stores/s3.md Regenerated snippet output to move deprecated attributes into a <details> block.

Comment thread templates/registry/markdown/attribute_table.j2 Outdated
Comment on lines +22 to +23
<!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
<!-- see templates/registry/markdown/attribute_namespace.md.j2 -->
Comment thread templates/registry/markdown/attributes_readme.md.j2
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-25 14:01:41 UTC.

  • Waiting on: Reviewers
  • Next step: Review the latest changes.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants