[chore] switch weaver to builtin attribute filter#3836
Conversation
a4c0e35 to
8aeb5e1
Compare
8aeb5e1 to
2a3a652
Compare
|
|
||
| ## Exception Attributes | ||
|
|
||
| This document defines the shared attributes used to report a single exception associated with a span or log. |
There was a problem hiding this comment.
Is this meaningful/useful?
|
|
||
| ## Host Attributes | ||
|
|
||
| A host is defined as a computing instance. For example, physical servers, virtual machines, switches or disk array. |
There was a problem hiding this comment.
Is this meaningful/useful? Or is the entity sufficient.
|
|
||
| ## Pprof specific attributes for the Profiling signal | ||
|
|
||
| Attributes specific to pprof that help convert from pprof to Profiling signal. |
There was a problem hiding this comment.
Is this meaningful/useful?
|
|
||
| ## Profile Frame Attributes | ||
|
|
||
| Describes the origin of a single frame in a Profile. |
There was a problem hiding this comment.
Perhaps an attribute group?
|
|
||
| ## Thread Attributes | ||
|
|
||
| These attributes may be used for any operation to store information about a thread that started a span. |
There was a problem hiding this comment.
Is this meaningful/useful?
dd79428 to
304349c
Compare
304349c to
570eef5
Compare
a174d30 to
61d6d57
Compare
1ddf54c to
1c35b39
Compare
a40ef01 to
d5b6dbd
Compare
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
There was a problem hiding this comment.
Pull request overview
This PR updates the registry markdown generation pipeline to rely on Weaver’s built-in semconv_grouped_attributes filter (supporting the schema v2 migration work) while still producing registry pages for deprecated/legacy namespaces via Jinja-driven rendering, and regenerates the affected docs output accordingly.
Changes:
- Switched registry template inputs from a custom jq attribute-group query to Weaver’s built-in
semconv_grouped_attributes(with exclusions for selected namespaces). - Updated Jinja templates to separate deprecated attributes into collapsible
<details>sections and adjust namespace/title mapping. - Regenerated registry markdown pages and updated cross-doc snippets where deprecated attributes are now grouped under a dedicated section.
Reviewed changes
Copilot reviewed 86 out of 86 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/registry/markdown/weaver.yaml | Switches registry generation filters to semconv_grouped_attributes and adds namespace/title maps/aliases. |
| templates/registry/markdown/attributes_readme.md.j2 | Updates attribute registry README generation to use root_namespace-based bundles and aliasing. |
| templates/registry/markdown/attribute_table.j2 | Splits deprecated vs non-deprecated attributes and renders deprecated attributes in a <details> section. |
| templates/registry/markdown/attribute_namespace.md.j2 | Updates per-namespace registry pages to be root_namespace/attributes-driven and append deprecated attributes via shared macro. |
| templates/registry/markdown/attribute_macros.j2 | Updates attribute linking behavior for registry references. |
| templates/registry/markdown/attribute_group_namespace.md.j2 | New template to keep attribute-group-based pages for excluded namespaces. |
| docs/registry/attributes/README.md | Regenerated attribute registry index with new namespace grouping/aliases. |
| docs/registry/attributes/android.md | Regenerated Android attribute registry page (deprecated section rendered via <details>). |
| docs/registry/attributes/app.md | Regenerated Application attribute registry page. |
| docs/registry/attributes/aspnetcore.md | Regenerated ASP.NET Core attribute registry page. |
| docs/registry/attributes/az.md | New deprecated-namespace page for az.* attributes. |
| docs/registry/attributes/azure.md | Regenerated Azure attribute registry page (content regrouped). |
| docs/registry/attributes/browser.md | Regenerated Browser attribute registry page. |
| docs/registry/attributes/cassandra.md | Regenerated Cassandra attribute registry page. |
| docs/registry/attributes/cloud.md | Regenerated Cloud attribute registry page. |
| docs/registry/attributes/cloudevents.md | Regenerated CloudEvents attribute registry page. |
| docs/registry/attributes/cloudfoundry.md | Regenerated CloudFoundry attribute registry page. |
| docs/registry/attributes/code.md | Regenerated Code attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/container.md | Regenerated Container attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/cpu.md | Regenerated CPU attribute registry page. |
| docs/registry/attributes/cpython.md | Regenerated CPython attribute registry page. |
| docs/registry/attributes/db.md | Regenerated Database attribute registry page (deprecated attributes moved into <details>). |
| docs/registry/attributes/deployment.md | Regenerated Deployment attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/device.md | Regenerated Device attribute registry page. |
| docs/registry/attributes/disk.md | Regenerated Disk attribute registry page. |
| docs/registry/attributes/dns.md | Regenerated DNS attribute registry page. |
| docs/registry/attributes/dotnet.md | Regenerated .NET attribute registry page. |
| docs/registry/attributes/elasticsearch.md | Regenerated Elasticsearch attribute registry page. |
| docs/registry/attributes/enduser.md | Regenerated Enduser attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/error.md | Regenerated Error attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/event.md | Regenerated Event attribute registry page (deprecated-only content via <details>). |
| docs/registry/attributes/exception.md | Regenerated Exception attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/faas.md | Regenerated FaaS attribute registry page. |
| docs/registry/attributes/feature-flag.md | Regenerated Feature Flag attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/file.md | Regenerated File attribute registry page (lock attributes merged into main table). |
| docs/registry/attributes/go.md | Regenerated Go attribute registry page. |
| docs/registry/attributes/graphql.md | Regenerated GraphQL attribute registry page. |
| docs/registry/attributes/hardware.md | Regenerated Hardware attribute registry page. |
| docs/registry/attributes/heroku.md | Regenerated Heroku attribute registry page. |
| docs/registry/attributes/host.md | Regenerated Host attribute registry page. |
| docs/registry/attributes/http.md | Regenerated HTTP attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/ios.md | Regenerated iOS attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/jsonrpc.md | Regenerated JSON-RPC attribute registry page. |
| docs/registry/attributes/jvm.md | Regenerated JVM attribute registry page. |
| docs/registry/attributes/k8s.md | Regenerated Kubernetes attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/linux.md | Regenerated Linux attribute registry page (deprecated-only content via <details>). |
| docs/registry/attributes/log.md | Regenerated Log attribute registry page (sections consolidated). |
| docs/registry/attributes/mainframe.md | Regenerated Mainframe attribute registry page. |
| docs/registry/attributes/message.md | New deprecated-namespace page for message.* attributes. |
| docs/registry/attributes/messaging.md | Regenerated Messaging attribute registry page (sections consolidated; deprecated section via <details>). |
| docs/registry/attributes/net.md | New deprecated-namespace page for net.* attributes. |
| docs/registry/attributes/network.md | Regenerated Network attribute registry page (deprecated net.* moved out). |
| docs/registry/attributes/nfs.md | Regenerated NFS attribute registry page. |
| docs/registry/attributes/nodejs.md | Regenerated Node.js attribute registry page. |
| docs/registry/attributes/oci.md | Regenerated OCI attribute registry page. |
| docs/registry/attributes/onc-rpc.md | Regenerated ONC RPC attribute registry page. |
| docs/registry/attributes/openshift.md | Regenerated Openshift attribute registry page. |
| docs/registry/attributes/opentracing.md | Regenerated OpenTracing attribute registry page. |
| docs/registry/attributes/oracle-cloud.md | Regenerated Oracle Cloud attribute registry page. |
| docs/registry/attributes/oracle.md | Regenerated Oracle attribute registry page (renamed from OracleDB content). |
| docs/registry/attributes/os.md | Regenerated Operating System attribute registry page. |
| docs/registry/attributes/otel.md | Regenerated OTel attribute registry page (sections consolidated; deprecated section via <details>). |
| docs/registry/attributes/other.md | New deprecated-namespace page for un-namespaced legacy attributes (e.g., state). |
| docs/registry/attributes/peer.md | Regenerated Peer attribute registry page (deprecated-only content via <details>). |
| docs/registry/attributes/pool.md | New deprecated-namespace page for legacy pool attributes. |
| docs/registry/attributes/pprof.md | Regenerated Pprof attribute registry page. |
| docs/registry/attributes/process.md | Regenerated Process attribute registry page (deprecated section via <details>; Linux cgroup attribute moved into main list). |
| docs/registry/attributes/profile.md | Regenerated Profile attribute registry page. |
| docs/registry/attributes/rpc.md | Regenerated RPC attribute registry page (deprecated section via <details>; message.* moved out). |
| docs/registry/attributes/service.md | Regenerated Service attribute registry page (peer-service attributes moved into main list). |
| docs/registry/attributes/signalr.md | Regenerated SignalR attribute registry page. |
| docs/registry/attributes/system.md | Regenerated System attribute registry page (sections consolidated; deprecated section via <details>). |
| docs/registry/attributes/telemetry.md | Regenerated Telemetry attribute registry page. |
| docs/registry/attributes/tls.md | Regenerated TLS attribute registry page (deprecated section via <details>). |
| docs/registry/attributes/url.md | Regenerated URL attribute registry page. |
| docs/registry/attributes/user-agent.md | Regenerated User-agent attribute registry page (sections consolidated). |
| docs/registry/attributes/user.md | Regenerated User attribute registry page. |
| docs/registry/attributes/v8js.md | Regenerated V8js attribute registry page. |
| docs/registry/attributes/webengine.md | Regenerated Webengine attribute registry page. |
| docs/registry/attributes/zos.md | Regenerated zOS attribute registry page. |
| docs/README.md | Adds redirect from the old oracledb registry route to oracle. |
| docs/cloud-providers/aws-sdk.md | Regenerated snippet output to move deprecated attributes into a <details> block. |
| docs/db/dynamodb.md | Regenerated snippets to move deprecated attributes into a <details> block (repeated sections). |
| docs/db/oracledb.md | Updates registry links from oracledb attributes page to the new oracle page. |
| docs/exceptions/exceptions-spans.md | Moves deprecated exception attribute into a <details> block. |
| docs/object-stores/s3.md | Regenerated snippet output to move deprecated attributes into a <details> block. |
| <!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
| <!-- see templates/registry/markdown/attribute_namespace.md.j2 --> |
Pull request dashboard statusStatus last refreshed: 2026-07-25 14:01:41 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Progresses #3808
Unblocks #3827
Changes
we have switched to the builtin attribute group filter to enable v2 to work without changes to docs.
To reduce diff, this pr uses jinja to create the deprecated attribute groups in the registry pages and not rely on attribute groups. The only viable alternative considering v2 syntax, would be to publish lots of attribute groups. However i don't think that is the best approach as it bloats our published artifact etc. All doc changes have been driven by updating the jinja and no manual changes to the docs were done.
This topic needs to be resolved before any v2 switch.
Important
Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.
Merge requirement checklist
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩